From: Stefan Hajnoczi <stefanha@gmail.com>
To: Ting Wang <kathy.wangting@huawei.com>
Cc: pbonzini@redhat.com, famz@redhat.com, qemu-devel@nongnu.org,
stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2] hmp: add info iothreads command
Date: Thu, 12 Mar 2015 14:03:33 +0000 [thread overview]
Message-ID: <20150312140333.GA948@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1426149324-116508-1-git-send-email-kathy.wangting@huawei.com>
[-- Attachment #1: Type: text/plain, Size: 709 bytes --]
On Thu, Mar 12, 2015 at 04:35:24PM +0800, Ting Wang wrote:
> +void hmp_info_iothreads(Monitor *mon, const QDict *qdict)
> +{
> + IOThreadInfoList *head = NULL, *elem = NULL;
> +
> + head = qmp_query_iothreads(NULL);
> + if (!head) {
> + monitor_printf(mon, "No iothread has been added\n");
> + return;
> + }
> +
> + elem = head;
> + while (elem) {
> + if (elem->value) {
> + monitor_printf(mon, "%s: thread_id=%ld\n", elem->value->id,
> + elem->value->thread_id);
%ld does not work on 32-bit hosts or 64-bit Windows hosts where long is
32-bit.
Please use the PRId64 format specifier macro for the int64_t thread_id.
[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2015-03-12 14:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-12 8:35 [Qemu-devel] [PATCH v2] hmp: add info iothreads command Ting Wang
2015-03-12 9:05 ` Fam Zheng
2015-03-12 9:08 ` Ting Wang
2015-03-12 9:32 ` Ting Wang
2015-03-12 9:41 ` Fam Zheng
2015-03-12 14:03 ` Stefan Hajnoczi [this message]
2015-03-13 1:32 ` Ting Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150312140333.GA948@stefanha-thinkpad.redhat.com \
--to=stefanha@gmail.com \
--cc=famz@redhat.com \
--cc=kathy.wangting@huawei.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).