From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40733) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YXS6V-00075z-E6 for qemu-devel@nongnu.org; Mon, 16 Mar 2015 06:18:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YXS6R-0007io-VV for qemu-devel@nongnu.org; Mon, 16 Mar 2015 06:18:35 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39567) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YXS6R-0007iF-QK for qemu-devel@nongnu.org; Mon, 16 Mar 2015 06:18:31 -0400 Date: Mon, 16 Mar 2015 10:18:24 +0000 From: "Daniel P. Berrange" Message-ID: <20150316101824.GC10189@redhat.com> References: <1426273797-11204-1-git-send-email-ehabkost@redhat.com> <1426273797-11204-2-git-send-email-ehabkost@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1426273797-11204-2-git-send-email-ehabkost@redhat.com> Subject: Re: [Qemu-devel] [PATCH 1/2] Revert "target-i386: Disable HLE and RTM on Haswell & Broadwell" Reply-To: "Daniel P. Berrange" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: libvir-list@redhat.com, qemu-devel@nongnu.org, donald.d.dugger@intel.com, jun.nakajima@intel.com, Paolo Bonzini , Jiri Denemark , Andreas =?utf-8?Q?F=C3=A4rber?= On Fri, Mar 13, 2015 at 04:09:56PM -0300, Eduardo Habkost wrote: > This reverts commit 13704e4c455770d500d6b87b117e32f0d01252c9. > > With the Intel microcode update that removed HLE and RTM, there will be > different kinds of Haswell and Broadwell CPUs out there: some that still > have the HLE and RTM features, and some that don't have the HLE and RTM > features. On both cases people may be willing to use the pc-*-2.3 > machine-types. > > So instead of making the CPU model results confusing by making it depend > on the machine-type, keep HLE and RTM on the existing Haswell and > Broadwell CPU models. The plan is to introduce "Haswell-noTSX" and > "Broadwell-noTSX" CPU models later, for people who have CPUs that don't > have TSX feature available. > > Signed-off-by: Eduardo Habkost Yep, in this situation we need to support both "models" of CPU, so changing based on machine type is inappropriate in this scenario. Reviewed-by: Daniel P. Berrange Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|