From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55249) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YXWnD-0004m0-Mq for qemu-devel@nongnu.org; Mon, 16 Mar 2015 11:19:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YXWnA-0001yv-Ez for qemu-devel@nongnu.org; Mon, 16 Mar 2015 11:18:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33241) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YXWnA-0001yr-9l for qemu-devel@nongnu.org; Mon, 16 Mar 2015 11:18:56 -0400 Date: Mon, 16 Mar 2015 16:18:51 +0100 From: Kevin Wolf Message-ID: <20150316151851.GF4707@noname.redhat.com> References: <1426228529-15969-1-git-send-email-famz@redhat.com> <20150313122329.GA9419@igalia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150313122329.GA9419@igalia.com> Subject: Re: [Qemu-devel] [PATCH] block/throttle: Use host clock type List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alberto Garcia Cc: pbonzini@redhat.com, Fam Zheng , qemu-devel@nongnu.org, Stefan Hajnoczi Am 13.03.2015 um 13:23 hat Alberto Garcia geschrieben: > On Fri, Mar 13, 2015 at 02:35:29PM +0800, Fam Zheng wrote: > > > Throttle timers won't make any progress when VCPU is not running, > > which is prone to stall the request queue in cases like utils, > > qtest, suspending, and live migration, unless carefully handled. > > Yes, this can be easily reproduced by stopping the VM and starting a > block-commit job. If the I/O in that device is throttled then the job > will be stalled. > > Then there's also the situation that we discussed in IRC: if the > block-commit job is ongoing and then we stop the VM, then the rest of > the data will be committed bypassing the throttling settings. But > that's not related to these changes. > > > Signed-off-by: Fam Zheng > > --- > > block.c | 2 +- > > tests/test-throttle.c | 14 +++++++------- > > 2 files changed, 8 insertions(+), 8 deletions(-) > > Reviewed-By: Alberto Garcia Thanks, applied to the block branch. Kevin