From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59174) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YXoog-0000Sd-Bn for qemu-devel@nongnu.org; Tue, 17 Mar 2015 06:33:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YXooc-0006YF-6g for qemu-devel@nongnu.org; Tue, 17 Mar 2015 06:33:42 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57763) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YXoob-0006Xr-Vf for qemu-devel@nongnu.org; Tue, 17 Mar 2015 06:33:38 -0400 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t2HAXboA025046 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Tue, 17 Mar 2015 06:33:37 -0400 Date: Tue, 17 Mar 2015 10:33:33 +0000 From: "Daniel P. Berrange" Message-ID: <20150317103333.GC6540@redhat.com> References: <1426509364-19513-1-git-send-email-berrange@redhat.com> <1426509364-19513-4-git-send-email-berrange@redhat.com> <1426577800.27188.20.camel@nilsson.home.kraxel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1426577800.27188.20.camel@nilsson.home.kraxel.org> Subject: Re: [Qemu-devel] [PATCH 3/3] ui: fix VNC websockets TLS integration Reply-To: "Daniel P. Berrange" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: qemu-devel@nongnu.org On Tue, Mar 17, 2015 at 08:36:40AM +0100, Gerd Hoffmann wrote: > Hi, > > > - Separate VNC auth scheme is tracked for websockets server, > > since it makes no sense to try to use VeNCrypt over a TLS > > enabled websockets connection. > > Hmm. That is a problem for the QAPI, the auth scheme is linked to the > vnc server not the socket. It seems straightforward enough to just do this: diff --git a/qapi-schema.json b/qapi-schema.json index d7c3eec..3362956 100644 --- a/qapi-schema.json +++ b/qapi-schema.json @@ -808,6 +808,7 @@ 'clients' : ['VncClientInfo'], 'auth' : 'VncPrimaryAuth', '*vencrypt' : 'VncVencryptSubAuth', + '*ws-auth' : 'VncPrimaryAuth', '*display' : 'str' } } And document that 'ws-auth' is used if server->websocket == true Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|