From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49735) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YXtLU-0008Cn-50 for qemu-devel@nongnu.org; Tue, 17 Mar 2015 11:23:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YXtLO-0000fR-1z for qemu-devel@nongnu.org; Tue, 17 Mar 2015 11:23:52 -0400 Date: Tue, 17 Mar 2015 15:23:30 +0000 From: Stefan Hajnoczi Message-ID: <20150317152330.GB11542@stefanha-thinkpad.redhat.com> References: <1425939893-14404-1-git-send-email-mark.cave-ayland@ilande.co.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="tsOsTdHNUZQcU9Ye" Content-Disposition: inline In-Reply-To: <1425939893-14404-1-git-send-email-mark.cave-ayland@ilande.co.uk> Subject: Re: [Qemu-devel] [RFC 0/2] macio: split out unaligned DMA access into separate functions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Mark Cave-Ayland Cc: kwolf@redhat.com, John Snow , qemu-ppc@nongnu.org, qemu-devel@nongnu.org, agraf@suse.de --tsOsTdHNUZQcU9Ye Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Mar 09, 2015 at 10:24:51PM +0000, Mark Cave-Ayland wrote: > This patchset attempts to separate out the IDE/ATAPI logic from the unali= gned > DMA access logic for macio which provides the following benefits: >=20 > 1) Reduced code complexity >=20 > The existing macio IDE/ATAPI functions were becoming extremely difficult = to > follow through the various callbacks. By splitting up the functions in th= is > way it becomes much easier to follow the DMA-specific sections of code. >=20 > 2) Future-proofing >=20 > If/when the block layer becomes able to handle unaligned DMA accesses dir= ectly > then it should be possible to switch out pmac_dma_read() and pmac_dma_wri= te() > with their unaligned-capable bdrv_*() equivalents without having to chang= e any > other logic. >=20 > 3) Fix intermittent CDROM detection under -M g3beige >=20 > The code refactoring now correctly handles non-block ATAPI transfers which > fixes the problem with intermittent CDROM detection with Darwin under > -M g3beige. >=20 > Signed-off-by: Mark Cave-Ayland >=20 >=20 > Mark Cave-Ayland (2): > macio: move unaligned DMA read code into separate pmac_dma_read() > function > macio: move unaligned DMA write code into separate pmac_dma_write() > function >=20 > hw/ide/macio.c | 487 +++++++++++++++++++++++---------------= ------ > include/hw/ppc/mac_dbdma.h | 4 - > 2 files changed, 254 insertions(+), 237 deletions(-) CCing John Snow, who is now maintaining IDE/ATAPI/AHCI. Stefan --tsOsTdHNUZQcU9Ye Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJVCEbyAAoJEJykq7OBq3PIxusH/0KAJVS68mKT7wLRiCfZYDXo mq4Zo/pAuppz3vOu86e7/XfVdVYfDzOCD1ZRwXuJDr9aNvqf5LPHoUE16oQRn1af OyT4H2zy4YFVJFOSb/PWUegI8yPPyF70MiEdELer1oMnWFyd9JMubDy1zYgTf0dH r8Tw+zIWLcR5M2m7rN7O3TTASNJBptrNqPiCjdAd82sASlaVV4A7YSAdIj7wTeye xJztybPyuhMVnWr9SZ497Aub3tm6OVbLZlhJlc1nBDSdkDZDyzfb0OXjFfnbCwNm Xc2gPVgdcaAGeGf9RCGuiwqmKo6JQoQ1YLhpWLnZm1/nVLFkHc61+60FuRd3axM= =5qDG -----END PGP SIGNATURE----- --tsOsTdHNUZQcU9Ye--