From: Stefan Hajnoczi <stefanha@gmail.com>
To: Shannon Zhao <zhaoshenglong@huawei.com>
Cc: peter.maydell@linaro.org, hangaohuai@huawei.com,
qemu-trivial@nongnu.org, mjt@tls.msk.ru, qemu-devel@nongnu.org,
peter.huangpeng@huawei.com, shannon.zhao@linaro.org,
pbonzini@redhat.com
Subject: Re: [Qemu-devel] [PATCH] hw/net/e1000: fix integer endianness
Date: Tue, 17 Mar 2015 17:05:45 +0000 [thread overview]
Message-ID: <20150317170545.GA13669@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1426224119-8352-1-git-send-email-zhaoshenglong@huawei.com>
[-- Attachment #1: Type: text/plain, Size: 567 bytes --]
On Fri, Mar 13, 2015 at 01:21:59PM +0800, Shannon Zhao wrote:
> It's detected by coverity.In is_vlan_packet s->mac_reg[VET] is
> unsigned int but is dereferenced as a narrower unsigned short.
> This may lead to unexpected results depending on machine
> endianness.
>
> Signed-off-by: Shannon Zhao <zhaoshenglong@huawei.com>
> Signed-off-by: Shannon Zhao <shannon.zhao@linaro.org>
> ---
> hw/net/e1000.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Thanks, applied to my net tree:
https://github.com/stefanha/qemu/commits/net
Stefan
[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2015-03-17 17:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-13 5:21 [Qemu-devel] [PATCH] hw/net/e1000: fix integer endianness Shannon Zhao
2015-03-13 12:51 ` Paolo Bonzini
2015-03-17 17:05 ` Stefan Hajnoczi [this message]
2015-03-18 1:28 ` Shannon Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150317170545.GA13669@stefanha-thinkpad.redhat.com \
--to=stefanha@gmail.com \
--cc=hangaohuai@huawei.com \
--cc=mjt@tls.msk.ru \
--cc=pbonzini@redhat.com \
--cc=peter.huangpeng@huawei.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=shannon.zhao@linaro.org \
--cc=zhaoshenglong@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).