From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54364) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YYDfq-0004vx-VX for qemu-devel@nongnu.org; Wed, 18 Mar 2015 09:06:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YYDfm-00058l-AX for qemu-devel@nongnu.org; Wed, 18 Mar 2015 09:06:14 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55819) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YYDfm-00058c-5M for qemu-devel@nongnu.org; Wed, 18 Mar 2015 09:06:10 -0400 Date: Wed, 18 Mar 2015 14:06:07 +0100 From: "Michael S. Tsirkin" Message-ID: <20150318140555-mutt-send-email-mst@redhat.com> References: <1426671309-13645-1-git-send-email-jasowang@redhat.com> <1426671309-13645-9-git-send-email-jasowang@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1426671309-13645-9-git-send-email-jasowang@redhat.com> Subject: Re: [Qemu-devel] [PATCH V4 08/19] virtio-net: fix the upper bound when trying to delete queues List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jason Wang Cc: cornelia.huck@de.ibm.com, qemu-devel@nongnu.org On Wed, Mar 18, 2015 at 05:34:58PM +0800, Jason Wang wrote: > Virtqueue were indexed from zero, so don't delete virtqueue whose > index is n->max_queues * 2 + 1. > > Cc: Michael S. Tsirkin > Signed-off-by: Jason Wang Bugfix? needed on master? stable? > --- > hw/net/virtio-net.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c > index 59f76bc..b6fac9c 100644 > --- a/hw/net/virtio-net.c > +++ b/hw/net/virtio-net.c > @@ -1309,7 +1309,7 @@ static void virtio_net_set_multiqueue(VirtIONet *n, int multiqueue) > > n->multiqueue = multiqueue; > > - for (i = 2; i <= n->max_queues * 2 + 1; i++) { > + for (i = 2; i < n->max_queues * 2 + 1; i++) { > virtio_del_queue(vdev, i); > } > > -- > 2.1.0