From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57357)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1YYF8T-0000JA-7h
	for qemu-devel@nongnu.org; Wed, 18 Mar 2015 10:39:57 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1YYF0l-0003T6-Ru
	for qemu-devel@nongnu.org; Wed, 18 Mar 2015 10:33:03 -0400
Received: from mx1.redhat.com ([209.132.183.28]:56925)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1YYF0l-0003SC-J7
	for qemu-devel@nongnu.org; Wed, 18 Mar 2015 10:31:55 -0400
Received: from int-mx13.intmail.prod.int.phx2.redhat.com
	(int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26])
	by mx1.redhat.com (Postfix) with ESMTPS id 2E9FF39ABC8
	for <qemu-devel@nongnu.org>; Wed, 18 Mar 2015 14:31:55 +0000 (UTC)
Date: Wed, 18 Mar 2015 15:31:52 +0100
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20150318152735-mutt-send-email-mst@redhat.com>
References: <1426687214-31206-1-git-send-email-kraxel@redhat.com>
	<1426687214-31206-3-git-send-email-kraxel@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1426687214-31206-3-git-send-email-kraxel@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 2/4] virtio-input: core code & base class
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org

On Wed, Mar 18, 2015 at 03:00:12PM +0100, Gerd Hoffmann wrote:
> This patch adds virtio-input support to qemu.  It brings a abstract
> base class providing core support, other classes can build on it to
> actually implement input devices.
> 
> virtio-input basically sends linux input layer events (evdev) over
> virtio.
> 
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>

Two questions before I looked at code:
- can you do a writeup for the virtio spec?
  might make it easier to review.
- does linux need to support this?
  if yes we'll eventually want to take
  the header from there.
  maybe split out guest/host ABI?
  also might be a good idea to make style there
  linux-compliant (e.g. no typedefs, add typedefs
  in another header).