From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47865)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1YYTUe-000331-3T
	for qemu-devel@nongnu.org; Thu, 19 Mar 2015 01:59:48 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1YYTUZ-0004XM-G1
	for qemu-devel@nongnu.org; Thu, 19 Mar 2015 01:59:44 -0400
Received: from mx1.redhat.com ([209.132.183.28]:59320)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1YYTUZ-0004T1-8g
	for qemu-devel@nongnu.org; Thu, 19 Mar 2015 01:59:39 -0400
Date: Thu, 19 Mar 2015 06:59:25 +0100
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20150319065901-mutt-send-email-mst@redhat.com>
References: <cover.1426494342.git.zhugh.fnst@cn.fujitsu.com>
	<849482771656da4717f071a85bd83e72e48f5ab0.1426494342.git.zhugh.fnst@cn.fujitsu.com>
	<20150316145713-mutt-send-email-mst@redhat.com>
	<550A2BFB.9070506@cn.fujitsu.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <550A2BFB.9070506@cn.fujitsu.com>
Subject: Re: [Qemu-devel] [RESEND PATCH v4 1/6] acpi,
 mem-hotplug: Add acpi_memory_slot_status() to get MemStatus
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Zhu Guihua <zhugh.fnst@cn.fujitsu.com>
Cc: qemu-devel@nongnu.org, tangchen@cn.fujitsu.com, pbonzini@redhat.com, izumi.taku@jp.fujitsu.com, guz.fnst@cn.fujitsu.com, imammedo@redhat.com

On Thu, Mar 19, 2015 at 09:52:59AM +0800, Zhu Guihua wrote:
> 
> On 03/16/2015 09:58 PM, Michael S. Tsirkin wrote:
> >On Mon, Mar 16, 2015 at 04:58:13PM +0800, Zhu Guihua wrote:
> >>From: Tang Chen <tangchen@cn.fujitsu.com>
> >>
> >>Add a new API named acpi_memory_slot_status() to obtain a single memory
> >>slot status. Doing this is because this procedure will be used by other
> >>functions in the next coming patches.
> >>
> >>Signed-off-by: Tang Chen <tangchen@cn.fujitsu.com>
> >>Signed-off-by: Zhu Guihua <zhugh.fnst@cn.fujitsu.com>
> >It's generally only OK to add API in a separate
> >patch from its use if the API is well documented.
> >There's 0 documentation here, so please just squash this
> >with the user so one can review without jumping
> >back and forth.
> 
> The new API will be used in several places. If I squash this with the
> user, I think the patch will be too large.
> 
> So I think it is better to add documentation here. what's your opinion?
> 
> Thanks,
> Zhu

That's fine too.