From: "Michael S. Tsirkin" <mst@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/4] virtio-input: core code & base class
Date: Thu, 19 Mar 2015 10:24:39 +0100 [thread overview]
Message-ID: <20150319102317-mutt-send-email-mst@redhat.com> (raw)
In-Reply-To: <1426751129.18873.16.camel@nilsson.home.kraxel.org>
On Thu, Mar 19, 2015 at 08:45:29AM +0100, Gerd Hoffmann wrote:
> Hi,
>
> > > > if yes we'll eventually want to take
> > > > the header from there.
> > >
> > > Yes, we can do that, for both linux input layer and virtio-input (once
> > > merged upstream) headers, then go build this on non-linux hosts too.
> > >
> > > I'd suggest to do that as incremental patch, after guest driver merge.
> >
> > Hmm but why? It's just code churn.
>
> Adding not-yet upstream files to the list of headers to sync over from
> linux isn't sane IMHO.
>
> cheers,
> Gerd
>
Of course it isn't. But you can sync it manually. Once it's upstream,
add it to list for automated sync.
Copy-pasting some defs from there in an unrelated header
seems worse.
--
MST
next prev parent reply other threads:[~2015-03-19 9:24 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-18 14:00 [Qemu-devel] [PATCH 0/4] virtio: add input device Gerd Hoffmann
2015-03-18 14:00 ` [Qemu-devel] [PATCH 1/4] pci: add PCI_CLASS_INPUT_* Gerd Hoffmann
2015-03-18 14:00 ` [Qemu-devel] [PATCH 2/4] virtio-input: core code & base class Gerd Hoffmann
2015-03-18 14:31 ` Michael S. Tsirkin
2015-03-18 15:31 ` Gerd Hoffmann
2015-03-18 16:58 ` Michael S. Tsirkin
2015-03-19 7:45 ` Gerd Hoffmann
2015-03-19 9:24 ` Michael S. Tsirkin [this message]
2015-03-19 11:33 ` Gerd Hoffmann
2015-03-19 11:37 ` Michael S. Tsirkin
2015-03-19 14:38 ` Gerd Hoffmann
2015-03-19 15:56 ` Michael S. Tsirkin
2015-03-18 14:00 ` [Qemu-devel] [PATCH 3/4] virtio-input: emulated devices Gerd Hoffmann
2015-03-18 14:00 ` [Qemu-devel] [PATCH 4/4] virtio-input: evdev passthrough Gerd Hoffmann
-- strict thread matches above, loose matches on Subject: below --
2014-06-03 8:42 [Qemu-devel] [PATCH 0/4] input: add virtio input devices Gerd Hoffmann
2014-06-03 8:42 ` [Qemu-devel] [PATCH 2/4] virtio-input: core code & base class Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150319102317-mutt-send-email-mst@redhat.com \
--to=mst@redhat.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).