From: Amit Shah <amit.shah@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Amos Kong" <akong@redhat.com>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Markus Armbruster" <armbru@redhat.com>,
"qemu list" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH 1/1] virtio: serial: expose a 'guest_writable' callback for users
Date: Thu, 19 Mar 2015 17:40:10 +0530 [thread overview]
Message-ID: <20150319121010.GB3279@grmbl.mre> (raw)
In-Reply-To: <CAFEAcA9dnAm9UuL4TaLNVBj=pFVU=jJ-4nh5trCUQj9AwpniiQ@mail.gmail.com>
On (Thu) 19 Mar 2015 [11:10:40], Peter Maydell wrote:
> On 19 March 2015 at 11:03, Amit Shah <amit.shah@redhat.com> wrote:
> > On (Thu) 19 Mar 2015 [11:21:04], Markus Armbruster wrote:
> >> Amit Shah <amit.shah@redhat.com> writes:
> >>
> >> > + * This is dependent on both, the guest and host ends being
> >> > + * connected.
> >>
> >> Sounds awkward. Perhaps: This is dependent on both the guest and
> >> thehost end being connected.
> >
> > or an added comma?
>
> No, I think extra commas would make things worse :-) I like
> Markus' phrasing.
>
> > I think it can go in later as a cleanup if this
> > patch goes in; I already sent pull req before seeing this mail..
>
> I would prefer you just reroll the pullreq. You won't miss
> the rc1 boat (that's not til next week).
v2 of the pull req sent.
Thanks,
Amit
next prev parent reply other threads:[~2015-03-19 12:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-19 7:35 [Qemu-devel] [PATCH 1/1] virtio: serial: expose a 'guest_writable' callback for users Amit Shah
2015-03-19 10:21 ` Markus Armbruster
2015-03-19 11:03 ` Amit Shah
2015-03-19 11:10 ` Peter Maydell
2015-03-19 12:10 ` Amit Shah [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-09-30 16:02 Amit Shah
2014-09-30 16:05 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150319121010.GB3279@grmbl.mre \
--to=amit.shah@redhat.com \
--cc=akong@redhat.com \
--cc=armbru@redhat.com \
--cc=kraxel@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).