From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59965)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <amit.shah@redhat.com>) id 1YYZHE-0002hY-H0
	for qemu-devel@nongnu.org; Thu, 19 Mar 2015 08:10:20 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <amit.shah@redhat.com>) id 1YYZHB-0002wg-Pa
	for qemu-devel@nongnu.org; Thu, 19 Mar 2015 08:10:16 -0400
Received: from mx1.redhat.com ([209.132.183.28]:55833)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <amit.shah@redhat.com>) id 1YYZHB-0002um-KQ
	for qemu-devel@nongnu.org; Thu, 19 Mar 2015 08:10:13 -0400
Date: Thu, 19 Mar 2015 17:40:10 +0530
From: Amit Shah <amit.shah@redhat.com>
Message-ID: <20150319121010.GB3279@grmbl.mre>
References: <8026596da2c98f4089c41f726354b91d557ee1fa.1426750554.git.amit.shah@redhat.com>
	<87zj79s2y7.fsf@blackfin.pond.sub.org>
	<20150319110318.GA16154@grmbl.mre>
	<CAFEAcA9dnAm9UuL4TaLNVBj=pFVU=jJ-4nh5trCUQj9AwpniiQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAFEAcA9dnAm9UuL4TaLNVBj=pFVU=jJ-4nh5trCUQj9AwpniiQ@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH 1/1] virtio: serial: expose a
 'guest_writable' callback for users
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: =?iso-8859-1?Q?Marc-Andr=E9?= Lureau <marcandre.lureau@redhat.com>, Amos Kong <akong@redhat.com>, Gerd Hoffmann <kraxel@redhat.com>, Markus Armbruster <armbru@redhat.com>, qemu list <qemu-devel@nongnu.org>

On (Thu) 19 Mar 2015 [11:10:40], Peter Maydell wrote:
> On 19 March 2015 at 11:03, Amit Shah <amit.shah@redhat.com> wrote:
> > On (Thu) 19 Mar 2015 [11:21:04], Markus Armbruster wrote:
> >> Amit Shah <amit.shah@redhat.com> writes:
> >>
> >> > +         * This is dependent on both, the guest and host ends being
> >> > +         * connected.
> >>
> >> Sounds awkward.  Perhaps: This is dependent on both the guest and
> >> thehost end being connected.
> >
> > or an added comma?
> 
> No, I think extra commas would make things worse :-) I like
> Markus' phrasing.
> 
> >  I think it can go in later as a cleanup if this
> > patch goes in; I already sent pull req before seeing this mail..
> 
> I would prefer you just reroll the pullreq. You won't miss
> the rc1 boat (that's not til next week).

v2 of the pull req sent.

Thanks,

		Amit