From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47040)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1YYYlm-0002s4-06
	for qemu-devel@nongnu.org; Thu, 19 Mar 2015 07:37:46 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1YYYlj-0007J3-85
	for qemu-devel@nongnu.org; Thu, 19 Mar 2015 07:37:45 -0400
Received: from mx1.redhat.com ([209.132.183.28]:59349)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1YYYlj-0007Ix-0s
	for qemu-devel@nongnu.org; Thu, 19 Mar 2015 07:37:43 -0400
Received: from int-mx09.intmail.prod.int.phx2.redhat.com
	(int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t2JBbgLD015972
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256
	verify=FAIL)
	for <qemu-devel@nongnu.org>; Thu, 19 Mar 2015 07:37:42 -0400
Date: Thu, 19 Mar 2015 12:37:39 +0100
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20150319123537-mutt-send-email-mst@redhat.com>
References: <1426687214-31206-1-git-send-email-kraxel@redhat.com>
	<1426687214-31206-3-git-send-email-kraxel@redhat.com>
	<20150318152735-mutt-send-email-mst@redhat.com>
	<1426692713.330.15.camel@nilsson.home.kraxel.org>
	<20150318174504-mutt-send-email-mst@redhat.com>
	<1426751129.18873.16.camel@nilsson.home.kraxel.org>
	<20150319102317-mutt-send-email-mst@redhat.com>
	<1426764781.18873.41.camel@nilsson.home.kraxel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1426764781.18873.41.camel@nilsson.home.kraxel.org>
Subject: Re: [Qemu-devel] [PATCH 2/4] virtio-input: core code & base class
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org

On Thu, Mar 19, 2015 at 12:33:01PM +0100, Gerd Hoffmann wrote:
>   Hi,
> 
> > > Adding not-yet upstream files to the list of headers to sync over from
> > > linux isn't sane IMHO.
> > > 
> > > cheers,
> > >   Gerd
> > > 
> > 
> > Of course it isn't. But you can sync it manually. Once it's upstream,
> > add it to list for automated sync.
> 
> Hmm, well, not that simple, there is no whitelist for virtio headers but
> a "*virtio*.h" glob.  So it'll simply sync automatic once landed
> upstream, and may get deleted by accident before.

Well no - by design we only update headers, never delete them.
If someone does manage to delete a header it's just a question of running
make before pushing upstream, isn't it?

> I've sent the guest kernel driver meanwhile, maybe this goes in quickly
> and and renders the whole discussion moot ;)
> 
> cheers,
>   Gerd
>