From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51960)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1YYac5-0001Fu-DJ
	for qemu-devel@nongnu.org; Thu, 19 Mar 2015 09:35:59 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1YYac2-0006cf-67
	for qemu-devel@nongnu.org; Thu, 19 Mar 2015 09:35:53 -0400
Received: from mx1.redhat.com ([209.132.183.28]:43753)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1YYac2-0006cX-0L
	for qemu-devel@nongnu.org; Thu, 19 Mar 2015 09:35:50 -0400
Date: Thu, 19 Mar 2015 14:35:45 +0100
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20150319141302-mutt-send-email-mst@redhat.com>
References: <1426756391-26585-1-git-send-email-kraxel@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1426756391-26585-1-git-send-email-kraxel@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 0/1] Add virtio-input driver.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: virtio-dev@lists.oasis-open.org, qemu-devel@nongnu.org, virtualization@lists.linux-foundation.org

On Thu, Mar 19, 2015 at 10:13:10AM +0100, Gerd Hoffmann wrote:
>   Hi,
> 
> This patch adds a virtio driver for input devices.
> 
> Specification:
>   https://www.kraxel.org/cgit/virtio-spec/log/?h=virtio-input
>   https://www.kraxel.org/virtio/virtio-v1.0-csprd03-virtio-input.html#x1-2640007


OK, I don't know which thread should I use for spec discussions.
Referring to that:

	"See file:///usr/include/linux/input.h."

Is likely not present on many systems, or might not include
the info you refer to.

 "type, code and value are filled according to the linux input layer
 (evdev) interface"

Which version?  How will non-linux guests know what to implement?


> 
> Qemu patches;
>   https://lists.gnu.org/archive/html/qemu-devel/2015-03/threads.html#03973
> 
> Gerd Hoffmann (1):
>   Add virtio-input driver.
> 
>  drivers/virtio/Kconfig            |  10 ++
>  drivers/virtio/Makefile           |   1 +
>  drivers/virtio/virtio_input.c     | 313 ++++++++++++++++++++++++++++++++++++++
>  include/uapi/linux/virtio_ids.h   |   1 +
>  include/uapi/linux/virtio_input.h |  65 ++++++++
>  5 files changed, 390 insertions(+)
>  create mode 100644 drivers/virtio/virtio_input.c
>  create mode 100644 include/uapi/linux/virtio_input.h
> 
> -- 
> 1.8.3.1