From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59224) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YYcoQ-0005A0-1P for qemu-devel@nongnu.org; Thu, 19 Mar 2015 11:56:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YYcoK-0004Vi-D6 for qemu-devel@nongnu.org; Thu, 19 Mar 2015 11:56:45 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59465) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YYcoK-0004Ug-4l for qemu-devel@nongnu.org; Thu, 19 Mar 2015 11:56:40 -0400 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t2JFudFU022058 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Thu, 19 Mar 2015 11:56:39 -0400 Date: Thu, 19 Mar 2015 16:56:36 +0100 From: "Michael S. Tsirkin" Message-ID: <20150319165401-mutt-send-email-mst@redhat.com> References: <1426687214-31206-1-git-send-email-kraxel@redhat.com> <1426687214-31206-3-git-send-email-kraxel@redhat.com> <20150318152735-mutt-send-email-mst@redhat.com> <1426692713.330.15.camel@nilsson.home.kraxel.org> <20150318174504-mutt-send-email-mst@redhat.com> <1426751129.18873.16.camel@nilsson.home.kraxel.org> <20150319102317-mutt-send-email-mst@redhat.com> <1426764781.18873.41.camel@nilsson.home.kraxel.org> <20150319123537-mutt-send-email-mst@redhat.com> <1426775939.10990.5.camel@nilsson.home.kraxel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1426775939.10990.5.camel@nilsson.home.kraxel.org> Subject: Re: [Qemu-devel] [PATCH 2/4] virtio-input: core code & base class List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: qemu-devel@nongnu.org On Thu, Mar 19, 2015 at 03:38:59PM +0100, Gerd Hoffmann wrote: > On Do, 2015-03-19 at 12:37 +0100, Michael S. Tsirkin wrote: > > On Thu, Mar 19, 2015 at 12:33:01PM +0100, Gerd Hoffmann wrote: > > > Hi, > > > > > > > > Adding not-yet upstream files to the list of headers to sync over from > > > > > linux isn't sane IMHO. > > > > > > > > > > cheers, > > > > > Gerd > > > > > > > > > > > > > Of course it isn't. But you can sync it manually. Once it's upstream, > > > > add it to list for automated sync. > > > > > > Hmm, well, not that simple, there is no whitelist for virtio headers but > > > a "*virtio*.h" glob. So it'll simply sync automatic once landed > > > upstream, and may get deleted by accident before. > > > > Well no - by design we only update headers, never delete them. > > Hmm? > > I'm talking about scripts/update-linux-headers.sh in the qemu tree. > That does a "rm -rf" followed by copying over the bits from linux > kernel. So when switching from my virtio-input branch back to master > (in the linux kernel source tree) and re-running the script the header > file will disappear ... > > Sounds like you are talking about something completely different. > > cheers, > Gerd What I referred to is that we don't do any of git add/git rm. User must manually run these to add/remove new headers. -- MST