From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41971) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YYdaH-0006jk-Ey for qemu-devel@nongnu.org; Thu, 19 Mar 2015 12:46:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YYdaB-00048J-GV for qemu-devel@nongnu.org; Thu, 19 Mar 2015 12:46:13 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52513) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YYdaB-00048E-8Z for qemu-devel@nongnu.org; Thu, 19 Mar 2015 12:46:07 -0400 Date: Thu, 19 Mar 2015 17:46:01 +0100 From: "Michael S. Tsirkin" Message-ID: <20150319174055-mutt-send-email-mst@redhat.com> References: <1426756391-26585-1-git-send-email-kraxel@redhat.com> <20150319141302-mutt-send-email-mst@redhat.com> <1426776404.10990.10.camel@nilsson.home.kraxel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1426776404.10990.10.camel@nilsson.home.kraxel.org> Subject: Re: [Qemu-devel] [PATCH 0/1] Add virtio-input driver. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: virtio-dev@lists.oasis-open.org, qemu-devel@nongnu.org, virtualization@lists.linux-foundation.org On Thu, Mar 19, 2015 at 03:46:44PM +0100, Gerd Hoffmann wrote: > On Do, 2015-03-19 at 14:35 +0100, Michael S. Tsirkin wrote: > > On Thu, Mar 19, 2015 at 10:13:10AM +0100, Gerd Hoffmann wrote: > > > Hi, > > > > > > This patch adds a virtio driver for input devices. > > > > > > Specification: > > > https://www.kraxel.org/cgit/virtio-spec/log/?h=virtio-input > > > https://www.kraxel.org/virtio/virtio-v1.0-csprd03-virtio-input.html#x1-2640007 > > > > > > OK, I don't know which thread should I use for spec discussions. > > Referring to that: > > > > "See file:///usr/include/linux/input.h." > > > > Is likely not present on many systems, or might not include > > the info you refer to. > > Dunno what the best way to deal with it is. Link to the version online > @ kernel.org instead maybe? > > > "type, code and value are filled according to the linux input layer > > (evdev) interface" > > > > Which version? > > Latest. As far I know there never ever have been incompatible changes > to the interface, and given this is userspace/kernel abi I don't expect > that to happen in the future. > > > How will non-linux guests know what to implement? > > There are some docs on the linux input layer and evdev events in > Documentation/input/ in the kernel tree. > > cheers, > Gerd Also, the spec needs to be rewritten a bit more formally, with conformance clauses separated from freetext description, and linked to from appropriate section. " motion events are send from the device" send->sent -- MST