From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34344) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YYey5-0004HQ-Cx for qemu-devel@nongnu.org; Thu, 19 Mar 2015 14:14:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YYey1-0007I2-Vt for qemu-devel@nongnu.org; Thu, 19 Mar 2015 14:14:53 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59480) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YYey1-0007Hj-O6 for qemu-devel@nongnu.org; Thu, 19 Mar 2015 14:14:49 -0400 Date: Thu, 19 Mar 2015 18:14:41 +0000 From: "Daniel P. Berrange" Message-ID: <20150319181441.GF9099@redhat.com> References: <1426273797-11204-1-git-send-email-ehabkost@redhat.com> <1426273797-11204-3-git-send-email-ehabkost@redhat.com> <20150316102451.GD10189@redhat.com> <20150319180227.GA18590@thinpad.lan.raisama.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20150319180227.GA18590@thinpad.lan.raisama.net> Subject: Re: [Qemu-devel] [PATCH 2/2] target-i386: Haswell-noTSX and Broadwell-noTSX Reply-To: "Daniel P. Berrange" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: libvir-list@redhat.com, qemu-devel@nongnu.org, donald.d.dugger@intel.com, jun.nakajima@intel.com, Paolo Bonzini , Jiri Denemark , Andreas =?utf-8?Q?F=C3=A4rber?= On Thu, Mar 19, 2015 at 03:02:27PM -0300, Eduardo Habkost wrote: > On Mon, Mar 16, 2015 at 10:24:51AM +0000, Daniel P. Berrange wrote: > > On Fri, Mar 13, 2015 at 04:09:57PM -0300, Eduardo Habkost wrote: > > > With the Intel microcode update that removed HLE and RTM, there will be > > > different kinds of Haswell and Broadwell CPUs out there: some that still > > > have the HLE and RTM features, and some that don't have the HLE and RTM > > > features. On both cases people may be willing to use the pc-*-2.3 > > > machine-types. > > > > > > So, to cover both cases, introduce Haswell-noTSX and Broadwell-noTSX CPU > > > models, for hosts that have Haswell and Broadwell CPUs without TSX support. > > > > > > Signed-off-by: Eduardo Habkost > > > > The addition of Haswell-noTSX looks good to me. > > > > I'm unclear on whether we truely need Broadwell-noTSX though. Did > > Intel actually ship any Broadwell production silicon in which the > > microcode disables this feature, or was it only a problem on > > pre-production samples of Broadwell ? If the latter, I'd say we > > don't need to have a Broadwell-noTSX model added. Perhaps Jun/Don > > can confirm from Intel's side. > > I've talked to Don and Jun, and they confirmed that a Broadwell-noTSX > CPU model will be needed, too. > > I see some Broadwell CPUs without TSX-NI on ark.intel.com, too, so the > TSX errata wouldn't be the only reason for needing the -noTSX model. Ok, your patch looks good. Reviewed-by: Daniel P. Berrange Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|