From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58478) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YZyF7-0001uH-G9 for qemu-devel@nongnu.org; Mon, 23 Mar 2015 05:01:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YZyF4-0008KO-90 for qemu-devel@nongnu.org; Mon, 23 Mar 2015 05:01:53 -0400 Date: Mon, 23 Mar 2015 09:01:45 +0000 From: "Richard W.M. Jones" Message-ID: <20150323090145.GC21124@redhat.com> References: <1427075508-12099-1-git-send-email-david@gibson.dropbear.id.au> <1427075508-12099-2-git-send-email-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1427075508-12099-2-git-send-email-david@gibson.dropbear.id.au> Subject: Re: [Qemu-devel] [PATCH v2 1/2] i6300esb: Correct endiannness List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Gibson Cc: qemu-devel@nongnu.org, qemu-ppc@nongnu.org, agraf@suse.de, mst@redhat.com On Mon, Mar 23, 2015 at 12:51:47PM +1100, David Gibson wrote: > The IO operations for the i6300esb watchdog timer are marked as > DEVICE_NATIVE_ENDIAN. This is not correct, and - as a PCI device - should > be DEVICE_LITTLE_ENDIAN. > > This allows i6300esb to work on ppc targets (yes, using an Intel ICH > derived device on ppc is a bit odd, but the driver exists on the guest > and there's no more obviously suitable watchdog device). > > Signed-off-by: David Gibson > --- > hw/watchdog/wdt_i6300esb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/watchdog/wdt_i6300esb.c b/hw/watchdog/wdt_i6300esb.c > index b2d158f..e694fa9 100644 > --- a/hw/watchdog/wdt_i6300esb.c > +++ b/hw/watchdog/wdt_i6300esb.c > @@ -369,7 +369,7 @@ static const MemoryRegionOps i6300esb_ops = { > i6300esb_mem_writel, > }, > }, > - .endianness = DEVICE_NATIVE_ENDIAN, > + .endianness = DEVICE_LITTLE_ENDIAN, > }; > > static const VMStateDescription vmstate_i6300esb = { ACK. Reviewed-by: Richard W.M. Jones Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-top is 'top' for virtual machines. Tiny program with many powerful monitoring features, net stats, disk stats, logging, etc. http://people.redhat.com/~rjones/virt-top