From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48049) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ya2gW-0004lr-3R for qemu-devel@nongnu.org; Mon, 23 Mar 2015 09:46:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ya2gN-0005tX-R5 for qemu-devel@nongnu.org; Mon, 23 Mar 2015 09:46:28 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37178) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ya2gN-0005tO-ID for qemu-devel@nongnu.org; Mon, 23 Mar 2015 09:46:19 -0400 Date: Mon, 23 Mar 2015 13:46:02 +0000 From: "Dr. David Alan Gilbert" Message-ID: <20150323134601.GF2368@work-vm> References: <1424883128-9841-1-git-send-email-dgilbert@redhat.com> <1424883128-9841-29-git-send-email-dgilbert@redhat.com> <20150323034108.GK25043@voom.fritz.box> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150323034108.GK25043@voom.fritz.box> Subject: Re: [Qemu-devel] [PATCH v5 28/45] postcopy: Incoming initialisation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Gibson Cc: aarcange@redhat.com, yamahata@private.email.ne.jp, quintela@redhat.com, qemu-devel@nongnu.org, amit.shah@redhat.com, pbonzini@redhat.com, yanghy@cn.fujitsu.com * David Gibson (david@gibson.dropbear.id.au) wrote: > On Wed, Feb 25, 2015 at 04:51:51PM +0000, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > Signed-off-by: Dr. David Alan Gilbert > > Reviewed-by: David Gibson > > Looks ok, apart from a misspelled comment: > > [snip] > > + /* > > + * We need the whole of RAM to be truly empty for postcopy, so things > > + * like ROMs and any data tables built during init must be zero'd > > + * - we're going to get the copy from the source anyway. > > + * (Precopy will just overwrite this data, so doesn't need the discard) > > + */ > > + if (postcopy_ram_discard_range(mis, host_addr, (host_addr + length - 1))) { > > + return -1; > > + } > > + > > + /* > > + * We also need the area to be normal 4k pages, not huge pages > > + * (otherwise we can't be sure we can atopically place the > > s/atopically/atomically/ Thanks! Dave > > > -- > David Gibson | I'll have my music baroque, and my code > david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ > | _way_ _around_! > http://www.ozlabs.org/~dgibson -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK