From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50230) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ya46B-0007Ff-B5 for qemu-devel@nongnu.org; Mon, 23 Mar 2015 11:17:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ya466-00046m-NS for qemu-devel@nongnu.org; Mon, 23 Mar 2015 11:17:03 -0400 Date: Mon, 23 Mar 2015 15:16:45 +0000 From: Stefan Hajnoczi Message-ID: <20150323151645.GE7934@stefanha-thinkpad.redhat.com> References: <1426811056-2202-1-git-send-email-jsnow@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="9l24NVCWtSuIVIod" Content-Disposition: inline In-Reply-To: <1426811056-2202-1-git-send-email-jsnow@redhat.com> Subject: Re: [Qemu-devel] [PATCH for-2.3 0/4] ahci: fix big endian PIO failures List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow Cc: pbonzini@redhat.com, afaerber@suse.de, qemu-block@nongnu.org, qemu-devel@nongnu.org --9l24NVCWtSuIVIod Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Mar 19, 2015 at 08:24:12PM -0400, John Snow wrote: > Two issues were unearthed from ahci-test on ppc64: >=20 > (1) The ahci_populate_sglist function had endian issues, > which is only likely to impact PIO transfers for buffers > greater than one sector, and >=20 > (2) multiple-sector PIO which I attempted to repair in > 36334faf has been broken for years. ahci-test didn't catch > this because it used a pattern that was identical for each > sector. >=20 > So the pattern has been corrected and the underlying issue > fixed. >=20 > This should clear up the test failures (properly) for ppc64. >=20 > John Snow (4): > ide: fix cmd_write_pio when nsectors > 1 > ide: fix cmd_read_pio when nsectors > 1 > ahci: Fix sglist offset manipulation for BE machines > ahci-test: improve rw buffer patterns >=20 > hw/ide/ahci.c | 2 +- > hw/ide/core.c | 10 ++++------ > tests/ahci-test.c | 36 ++++++++++++++++++++++++++++-------- > 3 files changed, 33 insertions(+), 15 deletions(-) >=20 > --=20 > 2.1.0 >=20 Reviewed-by: Stefan Hajnoczi --9l24NVCWtSuIVIod Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJVEC5dAAoJEJykq7OBq3PIVCkIAMd1mD2Qzw4swZbVKX4fzEUT RbsmSaxkKnTrLbhtWgHJIHbxbUL4ICF2OIDzJlg8psOVesKqxih8D3jELQf3JucZ VYK8chdfLE+S2sqL0x5aT9YtbUOFpIYnqo6MGaq7T0DPXL4YFlKXGbWWSzuOB9+i zikSuqar4tbKbHK48sxxDrAI4gPMJJKhbHwBp9pPDXIOWPSnp9MFLz5Eq/KUAtMg vScjqlaND4enQ83KyCFi1gENPllG8/6cr6uGzzjGzsDgei81ph7fUHcnpb43/k+g H5ATp3V2LRvlMm7swdbeoJLsPy6Lq5XGUmD9slpcsBSbKlMb8U0NBNWtbRsheQs= =uL39 -----END PGP SIGNATURE----- --9l24NVCWtSuIVIod--