From: Stefan Hajnoczi <stefanha@gmail.com>
To: Fam Zheng <famz@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Alberto Garcia <berto@igalia.com>,
qemu-devel <qemu-devel@nongnu.org>,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2] block: Switch to host monotonic clock for IO throttling
Date: Tue, 24 Mar 2015 13:29:43 +0000 [thread overview]
Message-ID: <20150324132943.GA1493@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <20150324011738.GB3955@ad.nay.redhat.com>
[-- Attachment #1: Type: text/plain, Size: 479 bytes --]
On Tue, Mar 24, 2015 at 09:17:38AM +0800, Fam Zheng wrote:
> Alberto saw that this patch also fixes the odd behavior: block jobs, which need
> to R/W a throttled BDS, will not make progress if VCPU is not running. If we
> don't consider this as a bug, we should document the inconsistency (confusion):
> if no throttling, they DO make progress after VCPU stopped.
This is a strong justification for the patch. Please make this the main
point in the commit description.
Stefan
[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]
prev parent reply other threads:[~2015-03-24 13:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-23 5:24 [Qemu-devel] [PATCH v2] block: Switch to host monotonic clock for IO throttling Fam Zheng
2015-03-23 8:10 ` Paolo Bonzini
2015-03-23 8:56 ` Alberto Garcia
2015-03-23 13:56 ` Stefan Hajnoczi
2015-03-23 13:58 ` Paolo Bonzini
2015-03-23 14:28 ` Stefan Hajnoczi
2015-03-23 14:49 ` Paolo Bonzini
2015-03-23 15:00 ` Stefan Hajnoczi
2015-03-23 15:02 ` Paolo Bonzini
2015-03-24 1:17 ` Fam Zheng
2015-03-24 13:29 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150324132943.GA1493@stefanha-thinkpad.redhat.com \
--to=stefanha@gmail.com \
--cc=berto@igalia.com \
--cc=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).