From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50077) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YaOu0-0004je-7Q for qemu-devel@nongnu.org; Tue, 24 Mar 2015 09:29:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YaOtv-0002Iq-4v for qemu-devel@nongnu.org; Tue, 24 Mar 2015 09:29:52 -0400 Received: from mail-wi0-x234.google.com ([2a00:1450:400c:c05::234]:35088) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YaOtu-0002Ik-UZ for qemu-devel@nongnu.org; Tue, 24 Mar 2015 09:29:47 -0400 Received: by wibdy8 with SMTP id dy8so74963816wib.0 for ; Tue, 24 Mar 2015 06:29:46 -0700 (PDT) Date: Tue, 24 Mar 2015 13:29:43 +0000 From: Stefan Hajnoczi Message-ID: <20150324132943.GA1493@stefanha-thinkpad.redhat.com> References: <1427088255-29885-1-git-send-email-famz@redhat.com> <20150323135612.GI9268@stefanha-thinkpad.redhat.com> <55101C22.6040108@redhat.com> <20150324011738.GB3955@ad.nay.redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="pf9I7BMVVzbSWLtt" Content-Disposition: inline In-Reply-To: <20150324011738.GB3955@ad.nay.redhat.com> Subject: Re: [Qemu-devel] [PATCH v2] block: Switch to host monotonic clock for IO throttling List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng Cc: Kevin Wolf , Paolo Bonzini , Alberto Garcia , qemu-devel , Stefan Hajnoczi --pf9I7BMVVzbSWLtt Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Mar 24, 2015 at 09:17:38AM +0800, Fam Zheng wrote: > Alberto saw that this patch also fixes the odd behavior: block jobs, which need > to R/W a throttled BDS, will not make progress if VCPU is not running. If we > don't consider this as a bug, we should document the inconsistency (confusion): > if no throttling, they DO make progress after VCPU stopped. This is a strong justification for the patch. Please make this the main point in the commit description. Stefan --pf9I7BMVVzbSWLtt Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJVEWbHAAoJEJykq7OBq3PIaUcH/3rX8dfQjoNYBtai2N/R6SA5 kesPxjpY0BXgRDrfemlx0ocgy3hduPqBgGOVASma3etWRXX12lhiXCXShHA/gHm4 DXvUyDwzGQjsGNbTCe1K5GMKjRDI8kKWPnlFS+8lACNbTrt2zylYOvfRN98FB8dD MVr89yT+JvFbdMcoXo8BTWEMEKpW9INnSsmmLGS7hVQICbBsj5fAqKKTE8B5lW/E bSaqwOPIqkA2F40ehNUno4bqEw63gyPgZVZWOvT/BaBeC8NgpQt08hUwdB1lpqqe A7CxaD8j9HAGy6Zd5cMYvY8USo6Uzx40iQjOj1vb/ZdvY0Nfgd0QvSzJZzV3ULA= =Ul2J -----END PGP SIGNATURE----- --pf9I7BMVVzbSWLtt--