From: Stefan Hajnoczi <stefanha@gmail.com>
To: Fam Zheng <famz@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
qemu-block@nongnu.org, pl@kamp.de, qemu-devel@nongnu.org,
qemu-stable@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 0/2] block: Fix unaligned zero write
Date: Tue, 24 Mar 2015 13:40:07 +0000 [thread overview]
Message-ID: <20150324134007.GC1493@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1427160230-4489-1-git-send-email-famz@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 815 bytes --]
On Tue, Mar 24, 2015 at 09:23:48AM +0800, Fam Zheng wrote:
> This fixes a segfault when doing unaligned zero write to an image that is 4k
> aligned.
>
> v2: Don't drop the unset of UNMAP flag. [Stefan, Peter]
>
> Reproducer:
>
> $ (echo "open -o file.align=4k blkdebug::img"; echo "write -z 512 1024") | qemu-io
>
> Fam Zheng (2):
> block: Fix unaligned zero write
> qemu-iotests: Test unaligned 4k zero write
>
> block.c | 45 ++++++++++++++++++++++++++++++++++++++------
> tests/qemu-iotests/033 | 47 +++++++++++++++++++++++++++++-----------------
> tests/qemu-iotests/033.out | 26 +++++++++++++++++++++++++
> 3 files changed, 95 insertions(+), 23 deletions(-)
Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block
Stefan
[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]
prev parent reply other threads:[~2015-03-24 13:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-24 1:23 [Qemu-devel] [PATCH v2 0/2] block: Fix unaligned zero write Fam Zheng
2015-03-24 1:23 ` [Qemu-devel] [PATCH v2 1/2] " Fam Zheng
2015-03-24 1:23 ` [Qemu-devel] [PATCH v2 2/2] qemu-iotests: Test unaligned 4k " Fam Zheng
2015-03-24 13:40 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150324134007.GC1493@stefanha-thinkpad.redhat.com \
--to=stefanha@gmail.com \
--cc=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=pl@kamp.de \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).