From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46973) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YaZBy-0007CH-O9 for qemu-devel@nongnu.org; Tue, 24 Mar 2015 20:29:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YaZBu-0003w6-OB for qemu-devel@nongnu.org; Tue, 24 Mar 2015 20:29:06 -0400 Date: Wed, 25 Mar 2015 11:04:39 +1100 From: David Gibson Message-ID: <20150325000439.GL25043@voom.fritz.box> References: <1427117764-23008-1-git-send-email-bharata@linux.vnet.ibm.com> <1427117764-23008-2-git-send-email-bharata@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="C7+XW987wMXbik5u" Content-Disposition: inline In-Reply-To: <1427117764-23008-2-git-send-email-bharata@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [RFC PATCH v2 01/23] spapr: enable PHB/CPU/LMB hotplug for pseries-2.3 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Bharata B Rao Cc: mdroth@linux.vnet.ibm.com, agraf@suse.de, qemu-devel@nongnu.org, qemu-ppc@nongnu.org, tyreld@linux.vnet.ibm.com, nfont@linux.vnet.ibm.com, imammedo@redhat.com, afaerber@suse.de --C7+XW987wMXbik5u Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Mar 23, 2015 at 07:05:42PM +0530, Bharata B Rao wrote: > From: Michael Roth >=20 > Introduce an sPAPRMachineClass sub-class of MachineClass to > handle sPAPR-specific machine configuration properties. >=20 > The 'dr_phb[cpu,lmb]_enabled' field of that class can be set as > part of machine-specific init code, and is then propagated > to sPAPREnvironment to conditional enable creation of DRC > objects and device-tree description to facilitate hotplug > of PHBs/CPUs/LMBs. >=20 > Since we can't migrate this state to older machine types, > default the option to false and only enable it for new > machine types. >=20 > Signed-off-by: Michael Roth > Signed-off-by: Bharata B Rao > [Added CPU and LMB bits] > Reviewed-by: Michael Roth > Reviewed-by: David Gibson [snip] > @@ -1854,11 +1882,15 @@ static const TypeInfo spapr_machine_2_2_info =3D { > static void spapr_machine_2_3_class_init(ObjectClass *oc, void *data) > { > MachineClass *mc =3D MACHINE_CLASS(oc); > + sPAPRMachineClass *smc =3D SPAPR_MACHINE_CLASS(oc); > =20 > mc->name =3D "pseries-2.3"; > mc->desc =3D "pSeries Logical Partition (PAPR compliant) v2.3"; > mc->alias =3D "pseries"; > mc->is_default =3D 1; > + smc->dr_phb_enabled =3D true; > + smc->dr_cpu_enabled =3D true; > + smc->dr_lmb_enabled =3D true; > } Presumably this will move to pseries-2.4 before merge. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --C7+XW987wMXbik5u Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJVEfuXAAoJEGw4ysog2bOSFlYQAKYU/5I+EWux8/Fp9cPY3LGG aT8X+it2hBvUHA96Y2HlK6bX+5767m+AqFO65coKuk/wEEjELoTSy4NSgEO7iuja 8CKG4kk/MvVHHhDk/ibBldOllpBvWheiyprMUZ5aNeOSh9l2HxydJ2pOPj4ycY+8 mGgDjwyQ89Z8a29UqdwGWXNl98gFRSzVpCaHKArdVWmUWDz0aCsGI6ewCqJCH09I oLy0qFQG1zBx2VJeqgnFoxFAzpOGl3epOhyb33Cw5tkhQEitlfGL/Z62t0Bkwv+7 u7gThvbt0diwtisEndyaF7fXFmOV/RnR4QHFoRwe8LNmsiCl7cKSjkPu+RBRVAWh NPS6UWnI1uzyCQbR43kv/gx9PGzGHKGrB0aGxyQlO0BN8UF+zD/0Q3uj/fuZxUhV Md6xNBM1tJMHLXkxqOy0EO46BU1+BiUxvHdrQ/I7QHbAysiL/HKYQtqFOH5XvWH4 gMb2YIA6TnoQjJHZJdLbPCyWztFx+LEVNGH9Pmpm/3oebr/KS92Scz6YZRUv2/Px 5nTd+EhhzOosFbsE8Fj2wvUcM1r4/390vSUxKPi4Ve/9qnphfKqAncQUNlRYPGHK vk8+soRajrjmCJDW6/AhNNJ7SM3K0tEDd9qZ/Az8azeV/ljmObQHsiQcm05VGWHX OQfgoJFX8jKpALnpCDbT =p9UP -----END PGP SIGNATURE----- --C7+XW987wMXbik5u--