From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52933) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yabvl-0003bO-O2 for qemu-devel@nongnu.org; Tue, 24 Mar 2015 23:24:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yabvb-0002Dd-4g for qemu-devel@nongnu.org; Tue, 24 Mar 2015 23:24:33 -0400 Date: Wed, 25 Mar 2015 14:12:39 +1100 From: David Gibson Message-ID: <20150325031239.GX25043@voom.fritz.box> References: <1427117764-23008-1-git-send-email-bharata@linux.vnet.ibm.com> <1427117764-23008-14-git-send-email-bharata@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="7v2SkOxZkOkgWk1E" Content-Disposition: inline In-Reply-To: <1427117764-23008-14-git-send-email-bharata@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [RFC PATCH v2 13/23] cpus: Add Error argument to cpu_exec_init() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Bharata B Rao Cc: mdroth@linux.vnet.ibm.com, agraf@suse.de, qemu-devel@nongnu.org, qemu-ppc@nongnu.org, tyreld@linux.vnet.ibm.com, nfont@linux.vnet.ibm.com, imammedo@redhat.com, afaerber@suse.de --7v2SkOxZkOkgWk1E Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Mar 23, 2015 at 07:05:54PM +0530, Bharata B Rao wrote: > Add an Error argument to cpu_exec_init() to let users collect the > error. Change all callers to currently pass NULL error argument. This cha= nge > is needed for the following reasons: >=20 > - A subsequent commit changes the CPU enumeration logic in cpu_exec_init() > resulting in cpu_exec_init() to fail if cpu_index values corresponding > to max_cpus have already been handed out. > - There is a thinking that cpu_exec_init() should be called from realize > rather than instance_init. With this change, those architectures > that can move this call into realize function can do so in a phased > manner. >=20 > Signed-off-by: Bharata B Rao Reviewed-by: David Gibson --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --7v2SkOxZkOkgWk1E Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJVEienAAoJEGw4ysog2bOSFQcQAJoL3Y4m63pr++D1X0VD4Ktn P5NrPjVu0R9VUqoeFnj6SxgJloGtVQkyxS0kjck45xavTXVPnxV6NhQdl8THc2j6 bf1yrVCTS+PeBienbJ00Daa9n6xYuI/NXq6xmulIoCnFtMGAgfNR8/FD6WrpZkSS n1mKveRXAL4yED3j6ItVUImXwg5gpj2AVqPAFC6nY12XX9mDssq6wC8Jd93ZEwbS aC9ZLGGrMabtuPMhE7cJKfr1dxvCZ44Z/KMVzyXBp0XE0ZycCbO59tEE1gQx10SG TSZwkO2gOCxaJxXXmrIPtg3KwnRkaygiKnHyQhlIzKbqQ0Zaz8ckTfm6tjmQBg8z xKCZ+NSOncIU4eWQQ8hX6kZuL4U/L3om7qOi+1jnrBCsDSKFLACwruR/fzfL5MvK 6gF/d2rn97dKaU2T3qjAWAyssTUbPGkAzKcgFPOa1Mqy7w7J0LaPLKHb+Kp3XJWa 9MbxtJhCSc6q0yzEIrToyQMNSifoGf7LPLhIYgZQPn9h6b58BIvdiz2xvYLeXa6K 8g+1upXRLNQgHtP2DEHd3SV57WZMzHKltZdAqwFK2JngLZbrgUJHGoGYTK+Yqtic vGvATswwS+vZ37/4mPPoETW9Lq7ALFYn/SU7ta+RMv4T9t/IJc2+kPtRe32GFhZV Lyo8iiX1xAOEHjnt0K+/ =KsoJ -----END PGP SIGNATURE----- --7v2SkOxZkOkgWk1E--