From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36778) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YaffA-0001lZ-FL for qemu-devel@nongnu.org; Wed, 25 Mar 2015 03:23:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yaff5-0005kt-G5 for qemu-devel@nongnu.org; Wed, 25 Mar 2015 03:23:40 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58387) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yaff5-0005kn-98 for qemu-devel@nongnu.org; Wed, 25 Mar 2015 03:23:35 -0400 Date: Wed, 25 Mar 2015 15:22:50 +0800 From: Fam Zheng Message-ID: <20150325072250.GA14724@ad.nay.redhat.com> References: <1427251352-14809-1-git-send-email-famz@redhat.com> <20150325071623.GA19368@igalia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150325071623.GA19368@igalia.com> Subject: Re: [Qemu-devel] [PATCH v3] block: Switch to host monotonic clock for IO throttling List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alberto Garcia Cc: Kevin Wolf , pbonzini@redhat.com, qemu-devel@nongnu.org, Stefan Hajnoczi On Wed, 03/25 08:16, Alberto Garcia wrote: > On Wed, Mar 25, 2015 at 10:42:32AM +0800, Fam Zheng wrote: > > > Block jobs are confusingly inconsistent between with and without > > throttling: if user sets a bps limit, starts a block job, then stops > > vm, the block job will not make any progress; in contrary, if user > > unsets the bps limit, the block job will run normally. > > Wait, that's not what happens: > > a) If you start a job then stop the vm then the job will be > completed immediately. > b) If you stop the vm then start the job then it won't make any > progress. > > This patch fixes b), but a) still happens. > Ah you're right, I put the order wrong. I'v just started looking at issue a). I'll fix the text. Fam