From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57124) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YakqY-0003Kc-1s for qemu-devel@nongnu.org; Wed, 25 Mar 2015 08:55:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YakqS-00032Z-Eq for qemu-devel@nongnu.org; Wed, 25 Mar 2015 08:55:45 -0400 Date: Wed, 25 Mar 2015 12:55:32 +0000 From: Stefan Hajnoczi Message-ID: <20150325125532.GC22940@stefanha-thinkpad.redhat.com> References: <1426274523-22661-1-git-send-email-jsnow@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="rQ2U398070+RC21q" Content-Disposition: inline In-Reply-To: <1426274523-22661-1-git-send-email-jsnow@redhat.com> Subject: Re: [Qemu-devel] [PATCH v2 0/2] ahci: test varying sector offsets List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow Cc: kwolf@redhat.com, qemu-devel@nongnu.org, qemu-block@nongnu.org --rQ2U398070+RC21q Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Mar 13, 2015 at 03:22:01PM -0400, John Snow wrote: > This is a re-send of patches 7 & 8 from an earlier series, > "[PATCH v2 0/8] ahci: add more IO tests" which ultimately got bounced > back because I used some glib functions that were too new. >=20 > v2: > - Patchew caught a pathing problem with the qemu-img binary; > the relative path produced by the Makefile does not prepend > "./", so I was relying on the /distro's/ qemu-img by accident. > Fix that by using realpath(). >=20 > v1: > - Removed "./" from the execution CLI. Now you can set an absolute or > relative path for QTEST_QEMU_IMG and it will work either way. The defau= lt > as generated by the Makefile will be a relative path. >=20 > - Removed the g_spawn_check_exit_status glib call from mkimg(). See the > in-line comments in patch 1/2 for correctness justification. >=20 > John Snow (2): > qtest/ahci: add qcow2 support to ahci-test > qtest/ahci: test different disk sectors >=20 > tests/Makefile | 1 + > tests/ahci-test.c | 84 +++++++++++++++++++++++++++++++++++++--------= ------ > tests/libqos/ahci.c | 10 +++--- > tests/libqos/ahci.h | 4 +-- > tests/libqos/libqos.c | 44 +++++++++++++++++++++++++++ > tests/libqos/libqos.h | 2 ++ > 6 files changed, 116 insertions(+), 29 deletions(-) Acked-by: Stefan Hajnoczi As in traditional Linux Acked-by. I've looked briefly at the patches and am happy. --rQ2U398070+RC21q Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJVErBEAAoJEJykq7OBq3PIuzAIAJ2A9JkEV26yp395fvT6XCkh fooUNUtOA6P979tXwYjjyiRKf6yR8/6Pxhkau46Dji2ru2DIoE05CCCHRzQZfM+m T28ah1w8CBz7X0nYUmKRJEJoyP4VIkVzCPBAYwx24oUbFwrZpnRBTHRIeL2NBShy 3VJb+e98A90tizuccJia8YMaRUr/VWSoy9HIofkDCUPKurtVNJ8EIoy3y2klyMvk ciU5M4jatEgZGh1kShIIbx+7zc3X8fgTx7Bix0XDExT2cxGjBDIZJi/gTzrd0q+l sFvlFAAj7UI1jXZrJ5C7KTsiooiEKiPddQJ4/CiSHyfB1EJVERAK6vHkXfWvRvs= =wo0X -----END PGP SIGNATURE----- --rQ2U398070+RC21q--