From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57934) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yakss-0006WH-0E for qemu-devel@nongnu.org; Wed, 25 Mar 2015 08:58:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yaksr-0003bH-5l for qemu-devel@nongnu.org; Wed, 25 Mar 2015 08:58:09 -0400 Date: Wed, 25 Mar 2015 12:57:59 +0000 From: Stefan Hajnoczi Message-ID: <20150325125759.GD22940@stefanha-thinkpad.redhat.com> References: <1426283454-15590-1-git-send-email-jsnow@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="LTeJQqWS0MN7I/qa" Content-Disposition: inline In-Reply-To: <1426283454-15590-1-git-send-email-jsnow@redhat.com> Subject: Re: [Qemu-devel] [PATCH v2 0/2] AHCI: avoid mapping stale guest memory List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow Cc: kwolf@redhat.com, pbonzini@redhat.com, qemu-devel@nongnu.org, qemu-block@nongnu.org --LTeJQqWS0MN7I/qa Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Mar 13, 2015 at 05:50:52PM -0400, John Snow wrote: > Currently, the AHCI device tries to re-map guest memory every time > the low or high address registers are written to, whether or not the > AHCI device is currently active. If the other register has stale > information in it, this may lead to runtime failures. >=20 > Reconfigure the AHCI device to ignore writes to these registers while > the device is active, and otherwise postpone the dma memory map until > the device becomes active. >=20 > If the mappings should for whatever reason fail, do not activate the > bits that tell the user the device has been started successfully. >=20 > v2: > - ahci_map_[clb|fis]_address now returns true on success > - PORT_CMD_LIST_ON and PORT_CMD_FIS_ON only turn on if the map succeeds > - Fix compiler warning due to changing context. >=20 > John Snow (2): > AHCI: Do not (re)map FB/CLB buffers while not running > AHCI: Protect cmd register >=20 > hw/ide/ahci.c | 76 +++++++++++++++++++++++++++++++++++++++++++++--------= ------ > hw/ide/ahci.h | 2 ++ > 2 files changed, 60 insertions(+), 18 deletions(-) >=20 > --=20 > 1.9.3 >=20 Reviewed-by: Stefan Hajnoczi --LTeJQqWS0MN7I/qa Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJVErDXAAoJEJykq7OBq3PIukAIAInCikBLz0Sf9csjllJP0WPl rFdJ/HO/kk4CludpazQLqGACqrXrvQTEKbc4+ECr2LWo80aR0Qv9AucuMiHmT5VU UNsvRZSpvvsnDwl1R5YQ5pao7H3EKh5sOUGDq3cQo+cboAPy1u4SSh2yx6EWVLyk 30YTD0IfDrnD+UMPLvF3DxqCEjWDekAUB5N/h84SpQYstOoYrdE0wwAZnBMqi3s4 jzpbb8FjmTRg7K+x9F+hYcxc6bmMoUaZcAd9Emu2j9cDshpPeTP/aRqLpjM0G81X 7wFigMd3n/x1/2CS4HZZQjMBruDLuwQOv5r32pTqxyzCjdMjcogT4WkfQN5S79w= =0XyJ -----END PGP SIGNATURE----- --LTeJQqWS0MN7I/qa--