From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35368)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1YalB0-0001lF-RQ
	for qemu-devel@nongnu.org; Wed, 25 Mar 2015 09:16:58 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1YalAx-00027I-0H
	for qemu-devel@nongnu.org; Wed, 25 Mar 2015 09:16:54 -0400
Received: from mx1.redhat.com ([209.132.183.28]:50313)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1YalAw-000276-SJ
	for qemu-devel@nongnu.org; Wed, 25 Mar 2015 09:16:50 -0400
Date: Wed, 25 Mar 2015 13:16:48 +0000
From: Stefan Hajnoczi <stefanha@redhat.com>
Message-ID: <20150325131648.GH22940@stefanha-thinkpad.redhat.com>
References: <1427221186-28404-1-git-send-email-jsnow@redhat.com>
	<1427221186-28404-3-git-send-email-jsnow@redhat.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="/9ZOS6odDaRI+0hI"
Content-Disposition: inline
In-Reply-To: <1427221186-28404-3-git-send-email-jsnow@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v4 2/4] configure: factor out supported
	flag check
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: John Snow <jsnow@redhat.com>
Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org


--/9ZOS6odDaRI+0hI
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, Mar 24, 2015 at 02:19:44PM -0400, John Snow wrote:
> +cc_has_warning_flag() {
> +    write_c_skeleton;
> +
>      # Use the positive sense of the flag when testing for -Wno-wombat
>      # support (gcc will happily accept the -Wno- form of unknown
>      # warning options).
> -    optflag="$(echo $flag | sed -e 's/^-Wno-/-W/')"
> -    if compile_prog "-Werror $optflag" "" ; then
> -	QEMU_CFLAGS="$QEMU_CFLAGS $flag"
> +    optflag="$(echo $1 | sed -e 's/^-Wno-/-W/')"
> +    compile_prog "-Werror $optflag" ""
> +}
> +
> +for flag in $gcc_flags; do
> +    if cc_has_warning_flag $flag --keep-tmpc; then

Please drop the unused --keep-tmpc option here.

Stefan

--/9ZOS6odDaRI+0hI
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQEcBAEBAgAGBQJVErVAAAoJEJykq7OBq3PIAZ4H/jtG+ITobbK9CjlF2oU/OEG7
0GMYLMu6YvcuOUTrGuoDj8lkA5FpOx9il8iUa/MHW94fqvHGRNHhJBaT7HBgMXu2
yF0G2t896ENWX2l4TMbwuU+mN1hbMZ/FLg51T8wnAaBBlg2EuSb+zbjICHyxqRLS
WmwrmW4zbZD6C3q2bw9dJnhoccFCZ7/b5RCD1gcor/yJn7CFoNz1TxWmhqbltfGo
CLfyWKtoVEy3EOGLXmKwaacjVA/WL4oNA4KRIRAbYOxVNMB/fQSbpMJf7cNOfRoS
7wHTuS2P7kZz2N2bxjHVpx01Sf6gVS467KAUrTmrqwPj5x7O46JGg/D7qTU5IMQ=
=xHQB
-----END PGP SIGNATURE-----

--/9ZOS6odDaRI+0hI--