[Qemu-devel] [PATCH] block: Document blockdev-add's immaturity

[Qemu-devel] [PATCH] block: Document blockdev-add's immaturity

[Markus Armbruster]

Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
 qapi/block-core.json | 4 ++++
 qmp-commands.hx      | 4 ++++
 2 files changed, 8 insertions(+)

diff --git a/qapi/block-core.json b/qapi/block-core.json
index f525b04..7873084 100644
--- a/qapi/block-core.json
+++ b/qapi/block-core.json
@@ -1721,6 +1721,10 @@
 #
 # Creates a new block device.
 #
+# This command is still a work in progress.  It doesn't support all
+# block drivers, it lacks a matching blockdev-del, and more.  Stay
+# away from it unless you want to help with its development.
+#
 # @options: block device options for the new device
 #
 # Since: 1.7
diff --git a/qmp-commands.hx b/qmp-commands.hx
index 7f68760..3a42ad0 100644
--- a/qmp-commands.hx
+++ b/qmp-commands.hx
@@ -3636,6 +3636,10 @@ blockdev-add
 
 Add a block device.
 
+This command is still a work in progress.  It doesn't support all
+block drivers, it lacks a matching blockdev-del, and more.  Stay away
+from it unless you want to help with its development.
+
 Arguments:
 
 - "options": block driver options
-- 
1.9.3

Re: [Qemu-devel] [PATCH] block: Document blockdev-add's immaturity

[Markus Armbruster]

Forgot to stick for-2.3 into the subject.

Re: [Qemu-devel] [for-2.3 PATCH] block: Document blockdev-add's immaturity

[Eric Blake]

[-- Attachment #1: Type: text/plain, Size: 444 bytes --]

On 03/20/2015 07:32 AM, Markus Armbruster wrote:
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
>  qapi/block-core.json | 4 ++++
>  qmp-commands.hx      | 4 ++++
>  2 files changed, 8 insertions(+)

Never hurts to document things like this, even after freeze :)

Reviewed-by: Eric Blake <eblake@redhat.com>


-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]

Re: [Qemu-devel] [PATCH] block: Document blockdev-add's immaturity

[Stefan Hajnoczi]

[-- Attachment #1: Type: text/plain, Size: 320 bytes --]

On Fri, Mar 20, 2015 at 02:32:17PM +0100, Markus Armbruster wrote:
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
>  qapi/block-core.json | 4 ++++
>  qmp-commands.hx      | 4 ++++
>  2 files changed, 8 insertions(+)

Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block

Stefan

[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]