* [Qemu-devel] [PATCH] acpi: Add missing GCC_FMT_ATTR to local function
@ 2015-03-20 17:11 Stefan Weil
2015-03-25 15:17 ` Michael Tokarev
0 siblings, 1 reply; 3+ messages in thread
From: Stefan Weil @ 2015-03-20 17:11 UTC (permalink / raw)
To: QEMU Trivial; +Cc: Stefan Weil, QEMU Developer, Michael S. Tsirkin
This fixes these gcc warnings (not enabled in default build):
hw/acpi/aml-build.c:83:5: warning:
function might be possible candidate for ‘gnu_printf’ format attribute [-Wsuggest-attribute=format]
hw/acpi/aml-build.c:88:5: warning:
function might be possible candidate for ‘gnu_printf’ format attribute [-Wsuggest-attribute=format]
Cc: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Stefan Weil <sw@weilnetz.de>
---
hw/acpi/aml-build.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c
index 6242908..d7945f6 100644
--- a/hw/acpi/aml-build.c
+++ b/hw/acpi/aml-build.c
@@ -68,7 +68,7 @@ build_append_nameseg(GArray *array, const char *seg)
g_array_append_vals(array, "____", ACPI_NAMESEG_LEN - len);
}
-static void
+static void GCC_FMT_ATTR(2, 0)
build_append_namestringv(GArray *array, const char *format, va_list ap)
{
/* It would be nicer to use g_string_vprintf but it's only there in 2.22 */
--
2.1.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] acpi: Add missing GCC_FMT_ATTR to local function
2015-03-20 17:11 [Qemu-devel] [PATCH] acpi: Add missing GCC_FMT_ATTR to local function Stefan Weil
@ 2015-03-25 15:17 ` Michael Tokarev
2015-03-25 15:20 ` Michael S. Tsirkin
0 siblings, 1 reply; 3+ messages in thread
From: Michael Tokarev @ 2015-03-25 15:17 UTC (permalink / raw)
To: Stefan Weil, QEMU Trivial; +Cc: QEMU Developer, Michael S. Tsirkin
20.03.2015 20:11, Stefan Weil wrote:
> This fixes these gcc warnings (not enabled in default build):
>
> hw/acpi/aml-build.c:83:5: warning:
> function might be possible candidate for ‘gnu_printf’ format attribute [-Wsuggest-attribute=format]
> hw/acpi/aml-build.c:88:5: warning:
> function might be possible candidate for ‘gnu_printf’ format attribute [-Wsuggest-attribute=format]
Not very important but does not hurt, applied to -trivial, thanks!
/mjt
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] acpi: Add missing GCC_FMT_ATTR to local function
2015-03-25 15:17 ` Michael Tokarev
@ 2015-03-25 15:20 ` Michael S. Tsirkin
0 siblings, 0 replies; 3+ messages in thread
From: Michael S. Tsirkin @ 2015-03-25 15:20 UTC (permalink / raw)
To: Michael Tokarev; +Cc: QEMU Trivial, Stefan Weil, QEMU Developer
On Wed, Mar 25, 2015 at 06:17:52PM +0300, Michael Tokarev wrote:
> 20.03.2015 20:11, Stefan Weil wrote:
> > This fixes these gcc warnings (not enabled in default build):
> >
> > hw/acpi/aml-build.c:83:5: warning:
> > function might be possible candidate for ‘gnu_printf’ format attribute [-Wsuggest-attribute=format]
> > hw/acpi/aml-build.c:88:5: warning:
> > function might be possible candidate for ‘gnu_printf’ format attribute [-Wsuggest-attribute=format]
>
> Not very important but does not hurt, applied to -trivial, thanks!
>
> /mjt
I'm preparing a pull request with this one, it's already
signed and testing is going to complete soon.
So I think you needn't bother.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-03-25 15:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-20 17:11 [Qemu-devel] [PATCH] acpi: Add missing GCC_FMT_ATTR to local function Stefan Weil
2015-03-25 15:17 ` Michael Tokarev
2015-03-25 15:20 ` Michael S. Tsirkin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).