From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59902) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yb8y9-00088S-5E for qemu-devel@nongnu.org; Thu, 26 Mar 2015 10:41:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yb8y4-0003OQ-TK for qemu-devel@nongnu.org; Thu, 26 Mar 2015 10:41:13 -0400 Received: from mail-wi0-f177.google.com ([209.85.212.177]:38257) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yb8y4-0003OI-K7 for qemu-devel@nongnu.org; Thu, 26 Mar 2015 10:41:08 -0400 Received: by wibgn9 with SMTP id gn9so88464767wib.1 for ; Thu, 26 Mar 2015 07:41:08 -0700 (PDT) Date: Thu, 26 Mar 2015 15:41:05 +0100 From: Eduardo Otubo Message-ID: <20150326144104.GB24566@vader> References: <1427279169-3213-1-git-send-email-eduardo.otubo@profitbricks.com> <1427279169-3213-2-git-send-email-eduardo.otubo@profitbricks.com> <87oanfx4i8.fsf@neno.neno> <87fv8rx33k.fsf@neno.neno> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="QKdGvSO+nmPlgiQ/" Content-Disposition: inline In-Reply-To: <87fv8rx33k.fsf@neno.neno> Subject: Re: [Qemu-devel] [PULL for v2.3 01/01] seccomp: update libseccomp version and remove arch restriction List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Juan Quintela Cc: pmoore@redhat.com, peter.maydell@linaro.org, qemu-devel@nongnu.org --QKdGvSO+nmPlgiQ/ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Mar 26, 2015 at 03=3D09=3D19PM +0100, Juan Quintela wrote: > Juan Quintela wrote: > > Eduardo Otubo wrote: > >> Libseccomp version updated to 2.2.0 and arch restriction to x86/x86_64 > >> is now removed. It's supposed to work on armv7l as well. > >> > >> Related bug: https://bugs.launchpad.net/qemu/+bug/1363641 > >> > >> Signed-off-by: Eduardo Otubo >=20 >=20 > Just in case anyone is interested, default virt-test output with current > qemu >=20 >=20 > 15:05:01 ERROR| Qemu output: > 15:05:01 ERROR| qemu-system-x86_64: -sandbox on: sandboxing request but s= eccomp=20 > is not compiled into this build > 15:05:01 ERROR|=20 > 15:05:01 ERROR|=20 > 15:05:01 ERROR| FAIL type_specific.io-github-autotest-qemu.migrate.defaul= t.tcp -> VMStartError: VM 'virt-tests-vm1' failed to start: Qemu is defunct. > Qemu output: > qemu-system-x86_64: -sandbox on: sandboxing request but seccomp is not co= mpiled into this build >=20 >=20 >=20 > Notice that you can "fix" the problem running with --qemu_sandbox=3Doff, > but breaking the main test suite just before release looks wrong? Is it possible to temporarely disable this feature in your testing environment while libseccomp is not updated? Regards, >=20 > Later, Juan. >=20 > > > > This prevent compliation on x86_64 on Fedora 21. > > > > (migration/next)$ make -j5 -C /scratch/tmp/next/all/ > > make: Entering directory '/scratch/tmp/next/all' > > config-host.mak is out-of-date, running configure > > > > ERROR: User requested feature libseccomp > > configure was not able to find it. > > Install libseccomp devel >=3D 2.2.0 > > > > Makefile:30: recipe for target 'config-host.mak' failed > > make: *** [config-host.mak] Error 1 > > make: Leaving directory '/scratch/tmp/next/all' > > (migration/next)$ rpm -qa | grep seccomp > > libseccomp-2.1.1-5.fc21.x86_64 > > libseccomp-devel-2.1.1-5.fc21.x86_64 > > libseccomp-debuginfo-2.1.1-5.fc21.x86_64 > > (migration/next)$=20 > > > > This was compiling correctly until this patch got in. And virt-test > > uses seccomp by default. > > > > Fedora 21 is less than 3 months old. Do we really want to avoid > > compilation there? > > > > Thanks, Juan. > > > > > >> --- > >> configure | 5 ++--- > >> 1 file changed, 2 insertions(+), 3 deletions(-) > >> > >> diff --git a/configure b/configure > >> index 589798e..cbe6495 100755 > >> --- a/configure > >> +++ b/configure > >> @@ -1848,14 +1848,13 @@ fi > >> # libseccomp check > >> =20 > >> if test "$seccomp" !=3D "no" ; then > >> - if test "$cpu" =3D "i386" || test "$cpu" =3D "x86_64" && > >> - $pkg_config --atleast-version=3D2.1.1 libseccomp; then > >> + if $pkg_config --atleast-version=3D2.2.0 libseccomp; then > >> libs_softmmu=3D"$libs_softmmu `$pkg_config --libs libseccomp`" > >> QEMU_CFLAGS=3D"$QEMU_CFLAGS `$pkg_config --cflags libseccomp`" > >> seccomp=3D"yes" > >> else > >> if test "$seccomp" =3D "yes"; then > >> - feature_not_found "libseccomp" "Install libseccomp devel = >=3D 2.1.1" > >> + feature_not_found "libseccomp" "Install libseccomp devel = >=3D 2.2.0" > >> fi > >> seccomp=3D"no" > >> fi --=20 Eduardo Otubo ProfitBricks GmbH --QKdGvSO+nmPlgiQ/ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJVFBqAAAoJEP0M/1sS+L0vAfAH/ili1tns15Z+PIfiYQ81piwK U/kFB/kEoaP1ifKen1wo04dYepRqnrPCoo6iUB3OS1igfYs94+ufHIskt79/pxk8 lva8MgmBDU6Gv5/c6XAHFvBkioxHjzCxqV9aTMoMum0XGvwwzIen891PJ8NcVwDe fg6TcrGti8Pj9hWuhxMTx8mDcydslq1CQX5tb4JXDhkw+Xo242SN4JufDDZm1/3E oGK5mJ3m4cotZE9rNrHbxE07PAc4lOPnp0bMKHW8Y73G2+ZfojGZ0wGWGz6LQdhd thO7Iw8pENRj0v4aq9LTOW47Lm0qJe7nUMwQVwkqe63++auy4CYH/cBrGYrAq0s= =5dlR -----END PGP SIGNATURE----- --QKdGvSO+nmPlgiQ/--