From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58214)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1YbIj4-0000Zp-R7
	for qemu-devel@nongnu.org; Thu, 26 Mar 2015 21:06:19 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1YbIj0-0008BB-Qz
	for qemu-devel@nongnu.org; Thu, 26 Mar 2015 21:06:18 -0400
Date: Fri, 27 Mar 2015 09:06:02 +0800
From: Fam Zheng <famz@redhat.com>
Message-ID: <20150327010602.GL14724@ad.nay.redhat.com>
References: <1427276174-9130-1-git-send-email-wency@cn.fujitsu.com>
	<1427276174-9130-7-git-send-email-wency@cn.fujitsu.com>
	<20150326072146.GJ14724@ad.nay.redhat.com>
	<5513B61D.3040705@cn.fujitsu.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <5513B61D.3040705@cn.fujitsu.com>
Subject: Re: [Qemu-devel] [RFC PATCH COLO v2 06/13] NBD client: implement
 block driver interfaces for block replication
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Wen Congyang <wency@cn.fujitsu.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Yang Hongyang <yanghy@cn.fujitsu.com>, Lai Jiangshan <laijs@cn.fujitsu.com>, qemu block <qemu-block@nongnu.org>, armbru@redhat.com, Jiang Yunhong <yunhong.jiang@intel.com>, Dong Eddie <eddie.dong@intel.com>, "Dr. David Alan Gilbert" <dgilbert@redhat.com>, qemu devel <qemu-devel@nongnu.org>, Gonglei <arei.gonglei@huawei.com>, Stefan Hajnoczi <stefanha@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Max Reitz <mreitz@redhat.com>, zhanghailiang <zhang.zhanghailiang@huawei.com>

On Thu, 03/26 15:32, Wen Congyang wrote:
> On 03/26/2015 03:21 PM, Fam Zheng wrote:
> > On Wed, 03/25 17:36, Wen Congyang wrote:
> >> Signed-off-by: Wen Congyang <wency@cn.fujitsu.com>
> >> Signed-off-by: zhanghailiang <zhang.zhanghailiang@huawei.com>
> >> Signed-off-by: Gonglei <arei.gonglei@huawei.com>
> >> ---
> >>  block/nbd.c | 49 +++++++++++++++++++++++++++++++++++++++++++++++++
> >>  1 file changed, 49 insertions(+)
> >>
> >> diff --git a/block/nbd.c b/block/nbd.c
> >> index 3faf865..753b322 100644
> >> --- a/block/nbd.c
> >> +++ b/block/nbd.c
> >> @@ -458,6 +458,52 @@ static void nbd_refresh_filename(BlockDriverState *bs)
> >>      bs->full_open_options = opts;
> >>  }
> >>  
> >> +static void nbd_start_replication(BlockDriverState *bs, COLOMode mode,
> >> +                                  Error **errp)
> >> +{
> >> +    BDRVNBDState *s = bs->opaque;
> >> +
> >> +    /*
> >> +     * TODO: support COLO_SECONDARY_MODE if we allow secondary
> >> +     * QEMU becoming primary QEMU.
> >> +     */
> >> +    if (mode != COLO_MODE_PRIMARY) {
> >> +        error_set(errp, QERR_INVALID_PARAMETER, "mode");
> > 
> > Please use error_setg. (Please grep the whole series :)
> 
> Why? QERR_INVALID_PARAMETER includes ERROR_CLASS_GENERIC_ERROR.

Because error classes are deprecated. See also commit 5b347c5410.

Fam