From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46047) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YbTvo-0007tI-VZ for qemu-devel@nongnu.org; Fri, 27 Mar 2015 09:04:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YbTvj-0006UR-Mr for qemu-devel@nongnu.org; Fri, 27 Mar 2015 09:04:12 -0400 Received: from mail-wg0-f50.google.com ([74.125.82.50]:35327) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YbTvj-0006UA-GU for qemu-devel@nongnu.org; Fri, 27 Mar 2015 09:04:07 -0400 Received: by wgdm6 with SMTP id m6so98724464wgd.2 for ; Fri, 27 Mar 2015 06:04:05 -0700 (PDT) Date: Fri, 27 Mar 2015 14:04:00 +0100 From: Thomas Huth Message-ID: <20150327140400.4b064ab4@tpl530> In-Reply-To: <1427384162-4994-4-git-send-email-cornelia.huck@de.ibm.com> References: <1427384162-4994-1-git-send-email-cornelia.huck@de.ibm.com> <1427384162-4994-4-git-send-email-cornelia.huck@de.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH for-2.3 3/4] s390x: do not include ram_addr.h List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cornelia Huck , qemu-devel@nongnu.org Cc: borntraeger@de.ibm.com, jfrei@linux.vnet.ibm.com, agraf@suse.de, Paolo Bonzini Am Thu, 26 Mar 2015 16:36:01 +0100 schrieb Cornelia Huck : > From: Paolo Bonzini > > ram_addr.h is an internal interface and it is not needed anyway by > hw/s390x/ipl.c. > > Cc: Christian Borntraeger > Signed-off-by: Paolo Bonzini > Message-Id: <1427295389-5054-1-git-send-email-pbonzini@redhat.com> > Signed-off-by: Christian Borntraeger > Signed-off-by: Cornelia Huck > --- > hw/s390x/ipl.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/hw/s390x/ipl.c b/hw/s390x/ipl.c > index 54d0835..5c86613 100644 > --- a/hw/s390x/ipl.c > +++ b/hw/s390x/ipl.c > @@ -14,7 +14,6 @@ > #include "sysemu/sysemu.h" > #include "cpu.h" > #include "elf.h" > -#include "exec/ram_addr.h" > #include "hw/loader.h" > #include "hw/sysbus.h" > #include "hw/s390x/virtio-ccw.h" Uh, IIRC I temporarily played around with qemu_get_ram_ptr() when I recently improved the BIOS loading in this file - and later forgot to remove that include file again - sorry! So of course, it should not be here. Thanks for cleaning it up! Reviewed-by: Thomas Huth