From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52739) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YcW6Z-0006fc-Nz for qemu-devel@nongnu.org; Mon, 30 Mar 2015 05:35:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YcW6V-0000cq-A6 for qemu-devel@nongnu.org; Mon, 30 Mar 2015 05:35:35 -0400 Received: from e28smtp05.in.ibm.com ([122.248.162.5]:54147) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YcW6U-0000cT-ET for qemu-devel@nongnu.org; Mon, 30 Mar 2015 05:35:31 -0400 Received: from /spool/local by e28smtp05.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 30 Mar 2015 15:05:27 +0530 Date: Mon, 30 Mar 2015 20:35:15 +1100 From: Gavin Shan Message-ID: <20150330093514.GC4716@shangw> References: <1427348102-5879-1-git-send-email-gwshan@linux.vnet.ibm.com> <1427348102-5879-3-git-send-email-gwshan@linux.vnet.ibm.com> <20150330024004.GF9908@voom.fritz.box> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150330024004.GF9908@voom.fritz.box> Subject: Re: [Qemu-devel] [PATCH 2/2] sPAPR: Reenable EEH functionality on reboot Reply-To: Gavin Shan List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Gibson Cc: qemu-devel@nongnu.org, Gavin Shan , agraf@suse.de, alex.williamson@redhat.com, qemu-ppc@nongnu.org On Mon, Mar 30, 2015 at 01:40:04PM +1100, David Gibson wrote: >On Thu, Mar 26, 2015 at 04:35:02PM +1100, Gavin Shan wrote: >> When rebooting the guest, some PEs might be in frozen state. The >> contained PCI devices won't work properly if their frozen states >> aren't cleared in time. One case running into this situation would >> be maximal EEH error times encountered in the guest. >> >> The patch reenables the EEH functinality on PEs on PHB's reset >> callback, which will clear their frozen states if needed. >> >> Signed-off-by: Gavin Shan > >Reviewed-by: David Gibson > Thanks for your review, David. >-- >David Gibson | I'll have my music baroque, and my code >david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ > | _way_ _around_! >http://www.ozlabs.org/~dgibson