From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33665)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1YcYyh-0005Xc-Hk
	for qemu-devel@nongnu.org; Mon, 30 Mar 2015 08:39:40 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1YcYyd-0002XW-HW
	for qemu-devel@nongnu.org; Mon, 30 Mar 2015 08:39:39 -0400
Received: from mx1.redhat.com ([209.132.183.28]:52768)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1YcYyd-0002WM-86
	for qemu-devel@nongnu.org; Mon, 30 Mar 2015 08:39:35 -0400
Date: Mon, 30 Mar 2015 14:39:31 +0200
From: Igor Mammedov <imammedo@redhat.com>
Message-ID: <20150330143931.390c56a8@nial.brq.redhat.com>
In-Reply-To: <55194119.5060507@redhat.com>
References: <1427717907-25027-1-git-send-email-imammedo@redhat.com>
	<55194119.5060507@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH for-2.3] pc: acpi: fix pvpanic regression
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: ghammer@redhat.com, rth@twiddle.net, qemu-devel@nongnu.org, mst@redhat.com

On Mon, 30 Mar 2015 14:27:05 +0200
Paolo Bonzini <pbonzini@redhat.com> wrote:

> 
> 
> On 30/03/2015 14:18, Igor Mammedov wrote:
> > Commit cd61cb2  pc: acpi-build: generate pvpanic device description dynamically
> > 
> > introduced regression changing pvpanic device HID from
> > QEMU0001 to QEMU0002.
> > Fix AML generated code so that pvpanic device
> > would keep its original HID. i.e. QEMU0001
> > 
> > Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> > Reported-by: Gal Hammer <ghammer@redhat.com>
> > ---
> >  hw/i386/acpi-build.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
> > index d0a5c85..e761005 100644
> > --- a/hw/i386/acpi-build.c
> > +++ b/hw/i386/acpi-build.c
> > @@ -788,7 +788,7 @@ build_ssdt(GArray *table_data, GArray *linker,
> >          scope = aml_scope("\\_SB.PCI0.ISA");
> >  
> >          dev = aml_device("PEVR");
> > -        aml_append(dev, aml_name_decl("_HID", aml_string("QEMU0002")));
> > +        aml_append(dev, aml_name_decl("_HID", aml_string("QEMU0001")));
> >  
> >          crs = aml_resource_template();
> >          aml_append(crs,
> > 
> 
> Pretty obvious, so I can take this through my tree.
Thanks!

I'll post additional test patch for 2.4
> 
> Paolo
>