* [Qemu-devel] [PATCH for-2.3] pc: acpi: fix pvpanic regression
@ 2015-03-30 12:18 Igor Mammedov
2015-03-30 12:27 ` Paolo Bonzini
2015-03-30 16:20 ` Michael S. Tsirkin
0 siblings, 2 replies; 4+ messages in thread
From: Igor Mammedov @ 2015-03-30 12:18 UTC (permalink / raw)
To: qemu-devel; +Cc: ghammer, pbonzini, rth, mst
Commit cd61cb2 pc: acpi-build: generate pvpanic device description dynamically
introduced regression changing pvpanic device HID from
QEMU0001 to QEMU0002.
Fix AML generated code so that pvpanic device
would keep its original HID. i.e. QEMU0001
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
Reported-by: Gal Hammer <ghammer@redhat.com>
---
hw/i386/acpi-build.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
index d0a5c85..e761005 100644
--- a/hw/i386/acpi-build.c
+++ b/hw/i386/acpi-build.c
@@ -788,7 +788,7 @@ build_ssdt(GArray *table_data, GArray *linker,
scope = aml_scope("\\_SB.PCI0.ISA");
dev = aml_device("PEVR");
- aml_append(dev, aml_name_decl("_HID", aml_string("QEMU0002")));
+ aml_append(dev, aml_name_decl("_HID", aml_string("QEMU0001")));
crs = aml_resource_template();
aml_append(crs,
--
2.1.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH for-2.3] pc: acpi: fix pvpanic regression
2015-03-30 12:18 [Qemu-devel] [PATCH for-2.3] pc: acpi: fix pvpanic regression Igor Mammedov
@ 2015-03-30 12:27 ` Paolo Bonzini
2015-03-30 12:39 ` Igor Mammedov
2015-03-30 16:20 ` Michael S. Tsirkin
1 sibling, 1 reply; 4+ messages in thread
From: Paolo Bonzini @ 2015-03-30 12:27 UTC (permalink / raw)
To: Igor Mammedov, qemu-devel; +Cc: ghammer, mst, rth
On 30/03/2015 14:18, Igor Mammedov wrote:
> Commit cd61cb2 pc: acpi-build: generate pvpanic device description dynamically
>
> introduced regression changing pvpanic device HID from
> QEMU0001 to QEMU0002.
> Fix AML generated code so that pvpanic device
> would keep its original HID. i.e. QEMU0001
>
> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> Reported-by: Gal Hammer <ghammer@redhat.com>
> ---
> hw/i386/acpi-build.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
> index d0a5c85..e761005 100644
> --- a/hw/i386/acpi-build.c
> +++ b/hw/i386/acpi-build.c
> @@ -788,7 +788,7 @@ build_ssdt(GArray *table_data, GArray *linker,
> scope = aml_scope("\\_SB.PCI0.ISA");
>
> dev = aml_device("PEVR");
> - aml_append(dev, aml_name_decl("_HID", aml_string("QEMU0002")));
> + aml_append(dev, aml_name_decl("_HID", aml_string("QEMU0001")));
>
> crs = aml_resource_template();
> aml_append(crs,
>
Pretty obvious, so I can take this through my tree.
Paolo
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH for-2.3] pc: acpi: fix pvpanic regression
2015-03-30 12:27 ` Paolo Bonzini
@ 2015-03-30 12:39 ` Igor Mammedov
0 siblings, 0 replies; 4+ messages in thread
From: Igor Mammedov @ 2015-03-30 12:39 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: ghammer, rth, qemu-devel, mst
On Mon, 30 Mar 2015 14:27:05 +0200
Paolo Bonzini <pbonzini@redhat.com> wrote:
>
>
> On 30/03/2015 14:18, Igor Mammedov wrote:
> > Commit cd61cb2 pc: acpi-build: generate pvpanic device description dynamically
> >
> > introduced regression changing pvpanic device HID from
> > QEMU0001 to QEMU0002.
> > Fix AML generated code so that pvpanic device
> > would keep its original HID. i.e. QEMU0001
> >
> > Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> > Reported-by: Gal Hammer <ghammer@redhat.com>
> > ---
> > hw/i386/acpi-build.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
> > index d0a5c85..e761005 100644
> > --- a/hw/i386/acpi-build.c
> > +++ b/hw/i386/acpi-build.c
> > @@ -788,7 +788,7 @@ build_ssdt(GArray *table_data, GArray *linker,
> > scope = aml_scope("\\_SB.PCI0.ISA");
> >
> > dev = aml_device("PEVR");
> > - aml_append(dev, aml_name_decl("_HID", aml_string("QEMU0002")));
> > + aml_append(dev, aml_name_decl("_HID", aml_string("QEMU0001")));
> >
> > crs = aml_resource_template();
> > aml_append(crs,
> >
>
> Pretty obvious, so I can take this through my tree.
Thanks!
I'll post additional test patch for 2.4
>
> Paolo
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH for-2.3] pc: acpi: fix pvpanic regression
2015-03-30 12:18 [Qemu-devel] [PATCH for-2.3] pc: acpi: fix pvpanic regression Igor Mammedov
2015-03-30 12:27 ` Paolo Bonzini
@ 2015-03-30 16:20 ` Michael S. Tsirkin
1 sibling, 0 replies; 4+ messages in thread
From: Michael S. Tsirkin @ 2015-03-30 16:20 UTC (permalink / raw)
To: Igor Mammedov; +Cc: ghammer, pbonzini, qemu-devel, rth
On Mon, Mar 30, 2015 at 02:18:27PM +0200, Igor Mammedov wrote:
> Commit cd61cb2 pc: acpi-build: generate pvpanic device description dynamically
>
> introduced regression changing pvpanic device HID from
> QEMU0001 to QEMU0002.
> Fix AML generated code so that pvpanic device
> would keep its original HID. i.e. QEMU0001
>
> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> Reported-by: Gal Hammer <ghammer@redhat.com>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> hw/i386/acpi-build.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
> index d0a5c85..e761005 100644
> --- a/hw/i386/acpi-build.c
> +++ b/hw/i386/acpi-build.c
> @@ -788,7 +788,7 @@ build_ssdt(GArray *table_data, GArray *linker,
> scope = aml_scope("\\_SB.PCI0.ISA");
>
> dev = aml_device("PEVR");
> - aml_append(dev, aml_name_decl("_HID", aml_string("QEMU0002")));
> + aml_append(dev, aml_name_decl("_HID", aml_string("QEMU0001")));
>
> crs = aml_resource_template();
> aml_append(crs,
> --
> 2.1.0
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-03-30 16:20 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-30 12:18 [Qemu-devel] [PATCH for-2.3] pc: acpi: fix pvpanic regression Igor Mammedov
2015-03-30 12:27 ` Paolo Bonzini
2015-03-30 12:39 ` Igor Mammedov
2015-03-30 16:20 ` Michael S. Tsirkin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).