From: Stefan Hajnoczi <stefanha@gmail.com>
To: Fam Zheng <famz@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v4] block/null: Latency simulation by adding new option "latency-ns"
Date: Mon, 30 Mar 2015 16:05:15 +0100 [thread overview]
Message-ID: <20150330150515.GM25181@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1426661368-572-1-git-send-email-famz@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 438 bytes --]
On Wed, Mar 18, 2015 at 02:49:28PM +0800, Fam Zheng wrote:
> +static coroutine_fn int null_co_common(BlockDriverState *bs)
> +{
> + BDRVNullState *s = bs->opaque;
> +
> + /* Only emulate latency after vcpu is running. */
> + if (s->latency_ns && qemu_clock_get_us(QEMU_CLOCK_VIRTUAL) > 0) {
This seems a little hacky. There is runstate_is_running(), which
doesn't depend on the CPU clock offset being 0 in qemu_clock_get_us().
[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]
prev parent reply other threads:[~2015-03-30 15:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-18 6:49 [Qemu-devel] [PATCH v4] block/null: Latency simulation by adding new option "latency-ns" Fam Zheng
2015-03-18 12:26 ` Eric Blake
2015-03-30 15:05 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150330150515.GM25181@stefanha-thinkpad.redhat.com \
--to=stefanha@gmail.com \
--cc=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).