From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47749) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YcbXx-0002WR-Sl for qemu-devel@nongnu.org; Mon, 30 Mar 2015 11:24:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YcbXs-00009f-TO for qemu-devel@nongnu.org; Mon, 30 Mar 2015 11:24:13 -0400 Received: from mail-wi0-x229.google.com ([2a00:1450:400c:c05::229]:35271) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YcbXs-00009S-N0 for qemu-devel@nongnu.org; Mon, 30 Mar 2015 11:24:08 -0400 Received: by wicne17 with SMTP id ne17so35910084wic.0 for ; Mon, 30 Mar 2015 08:24:07 -0700 (PDT) Date: Mon, 30 Mar 2015 16:24:02 +0100 From: Stefan Hajnoczi Message-ID: <20150330152402.GP25181@stefanha-thinkpad.redhat.com> References: <20150326185250.GA23415@igalia.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="i0LFOk513GRb+T2w" Content-Disposition: inline In-Reply-To: <20150326185250.GA23415@igalia.com> Subject: Re: [Qemu-devel] [PATCH v4 0/7] Block Throttle Group Support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alberto Garcia Cc: Kevin Wolf , qemu-devel@nongnu.org, Stefan Hajnoczi --i0LFOk513GRb+T2w Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Mar 26, 2015 at 07:52:50PM +0100, Alberto Garcia wrote: > On Thu, Mar 26, 2015 at 07:24:54PM +0200, Alberto Garcia wrote: >=20 > > - The creation/destruction of ThrottleTimers is now handled internally > > when a BlockDriverState is added/removed from a group, since > > there's not much point on keeping them separate. This also hides > > the timer callbacks from the outside, which makes things a bit > > nicer and easier for some of the other changes included in these > > series. >=20 > Hmm... this actually breaks the new test because now BDS are required > to have an AioContext attached when they're added to a group, which > doesn't happen in qtest: >=20 > bdrv =3D bdrv_new(); > throttle_group_register_bs(bdrv, "bar"); >=20 > I'm unsure of how to proceed with this, I don't see a clear way to > attach the AioContext here (unless I do bdrv->aio_context =3D ctx). > Suggestions are welcome. This only happens because the test hasn't called qemu_init_main_loop(). Should be an easy fix. Stefan --i0LFOk513GRb+T2w Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJVGWqSAAoJEJykq7OBq3PIZZ4IAJZoni/RYdkfcEeKCV+0/MNd 5ZFb0XEoeUT5R7a99OpIJgyzqCIf2XBZAWnxq1on33P8npqrfYgH0c1HjekeNBqO 4lhIMW5pSNenFqFBMovQpyC7y4Ba5+RXtOhEVGSKDEVmw24bkzKnRjG+MhcJ4D3G GbXJN7kk5CYGZBoKl6sVlq8XH2SHW/HooymQOzC0jnxICdRwaTkil6HXhOv+AqgI 4BpkP8BREq5s5VybOkrHNZzRj4K0oOd7a33viRiEhJgWlsB/TLfoOiNCUfjoMe5t kCyGPJzinm8gyfW71k102jZZdCU5IpYJArIxTlfw8h4mnh6P8zUqXHroTVcKInQ= =5a16 -----END PGP SIGNATURE----- --i0LFOk513GRb+T2w--