From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49290)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1Yca4W-0004CW-MN
	for qemu-devel@nongnu.org; Mon, 30 Mar 2015 09:49:45 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1Yca4T-00025J-D5
	for qemu-devel@nongnu.org; Mon, 30 Mar 2015 09:49:44 -0400
Received: from mx1.redhat.com ([209.132.183.28]:46465)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1Yca4T-00022p-7M
	for qemu-devel@nongnu.org; Mon, 30 Mar 2015 09:49:41 -0400
Date: Mon, 30 Mar 2015 15:49:36 +0200
From: Igor Mammedov <imammedo@redhat.com>
Message-ID: <20150330154936.2503d224@nial.brq.redhat.com>
In-Reply-To: <CAOVGsrM_weMN+bVihnCEkb=7exJhCBo-r9n1=iadu2RO8ByzsQ@mail.gmail.com>
References: <1427554013-3535-1-git-send-email-fishman@saucelabs.com>
	<20150330143643.304edf0f@nial.brq.redhat.com>
	<CAOVGsrM_weMN+bVihnCEkb=7exJhCBo-r9n1=iadu2RO8ByzsQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC] acpi: add reset register to fadt
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Reza Jelveh <fishman@saucelabs.com>
Cc: qemu-devel@nongnu.org

On Mon, 30 Mar 2015 15:27:26 +0200
Reza Jelveh <fishman@saucelabs.com> wrote:

> On Mon, Mar 30, 2015 at 2:36 PM, Igor Mammedov <imammedo@redhat.com> wrote:
> 
> > you are extending structure beyond of what specified by ACPI 1.0b spec,
> > that might break guests.
> > We probably can't change revision since Windows ACPI implementation
> > is mostly 1.0b based so we are stuck with it.
> > Patch needs to be tested with Windows guests starting with XP.
> >
> 
> Works fine with XP as long as you don't use q35, but i guess that's
> unsupported by xp by default.
what about other windows versions?

> 
> 
> > related issue,
> > adding fields without changing major version to a corresponding
> > one doesn't look correct.
> >
> 
> What do you suggest? saying we support 2.0a just because of introducing
> reset_reg is not really valid is it?
Try to check whether windows works fine with a newer revision,
if it is, we can create revX FADT structure and use in with new machine types.
In that case we could consider implementing rev5 table so it could be reused
in ARM target.