From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34965) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YccQn-0006JS-P3 for qemu-devel@nongnu.org; Mon, 30 Mar 2015 12:20:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YccQg-0004j8-Kx for qemu-devel@nongnu.org; Mon, 30 Mar 2015 12:20:53 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55300) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YccQg-0004j2-Dj for qemu-devel@nongnu.org; Mon, 30 Mar 2015 12:20:46 -0400 Date: Mon, 30 Mar 2015 18:20:42 +0200 From: "Michael S. Tsirkin" Message-ID: <20150330181958-mutt-send-email-mst@redhat.com> References: <1427717907-25027-1-git-send-email-imammedo@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1427717907-25027-1-git-send-email-imammedo@redhat.com> Subject: Re: [Qemu-devel] [PATCH for-2.3] pc: acpi: fix pvpanic regression List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: ghammer@redhat.com, pbonzini@redhat.com, qemu-devel@nongnu.org, rth@twiddle.net On Mon, Mar 30, 2015 at 02:18:27PM +0200, Igor Mammedov wrote: > Commit cd61cb2 pc: acpi-build: generate pvpanic device description dynamically > > introduced regression changing pvpanic device HID from > QEMU0001 to QEMU0002. > Fix AML generated code so that pvpanic device > would keep its original HID. i.e. QEMU0001 > > Signed-off-by: Igor Mammedov > Reported-by: Gal Hammer Acked-by: Michael S. Tsirkin Reviewed-by: Michael S. Tsirkin > --- > hw/i386/acpi-build.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c > index d0a5c85..e761005 100644 > --- a/hw/i386/acpi-build.c > +++ b/hw/i386/acpi-build.c > @@ -788,7 +788,7 @@ build_ssdt(GArray *table_data, GArray *linker, > scope = aml_scope("\\_SB.PCI0.ISA"); > > dev = aml_device("PEVR"); > - aml_append(dev, aml_name_decl("_HID", aml_string("QEMU0002"))); > + aml_append(dev, aml_name_decl("_HID", aml_string("QEMU0001"))); > > crs = aml_resource_template(); > aml_append(crs, > -- > 2.1.0