From: David Gibson <david@gibson.dropbear.id.au>
To: Markus Armbruster <armbru@redhat.com>
Cc: agraf@suse.de, mst@redhat.com, qemu-devel@nongnu.org,
michael@walle.cc, lcapitulino@redhat.com, blauwirbel@gmail.com,
andreas.faerber@web.de, qemu-ppc@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/6] Split serial-isa into its own config option
Date: Tue, 31 Mar 2015 16:36:34 +1100 [thread overview]
Message-ID: <20150331053634.GC13452@voom.redhat.com> (raw)
In-Reply-To: <87y4mfvt94.fsf@blackfin.pond.sub.org>
[-- Attachment #1: Type: text/plain, Size: 3225 bytes --]
On Mon, Mar 30, 2015 at 09:28:39AM +0200, Markus Armbruster wrote:
> David Gibson <david@gibson.dropbear.id.au> writes:
>
> > At present, the core device model code for 8250-like serial ports
> > (serial.c) and the code for serial ports attached to ISA-style legacy IO
> > (serial-isa.c) are both controlled by the CONFIG_ISA variable.
> >
> > There are lots and lots of embedded platforms that have 8250-like serial
> > ports but have never had anything resembling ISA legacy IO. Therefore,
> > split serial-isa into its own CONFIG_SERIAL_ISA option so it can be
> > disabled for platforms where it's not appropriate.
> >
> > For now, I enabled CONFIG_SERIAL_ISA in every default-config where
> > CONFIG_SERIAL is enabled, excepting microblaze and xtensa, where it's
> > pretty clear there isn't legacy IO stuff.
>
> Related: in PATCH 6, you configure ISA support away for a bunch of
> machines. This includes device isabus-bridge. You keep it for machines
> sporting PCI.
>
> > Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
> > ---
> > default-configs/alpha-softmmu.mak | 1 +
> > default-configs/arm-softmmu.mak | 1 +
> > default-configs/i386-softmmu.mak | 1 +
> > default-configs/mips-softmmu.mak | 1 +
> > default-configs/mips64-softmmu.mak | 1 +
> > default-configs/mips64el-softmmu.mak | 1 +
> > default-configs/mipsel-softmmu.mak | 1 +
> > default-configs/moxie-softmmu.mak | 1 +
> > default-configs/ppc-softmmu.mak | 1 +
> > default-configs/ppc64-softmmu.mak | 1 +
> > default-configs/ppcemb-softmmu.mak | 1 +
> > default-configs/sh4-softmmu.mak | 1 +
> > default-configs/sh4eb-softmmu.mak | 1 +
> > default-configs/sparc64-softmmu.mak | 1 +
> > default-configs/x86_64-softmmu.mak | 1 +
> > hw/char/Makefile.objs | 3 ++-
> > 16 files changed, 17 insertions(+), 1 deletion(-)
>
> In addition for not adding CONFIG_SERIAL_ISA to microblaze and xtensa,
> you don't seem to add it to or32. If that's correct, please adjust your
> commit message.
Oops. I think I first wrote this patch on a downstream qemu, and
forgot to update the commit message when the or32 case was added when
I ported upstream.
Will fix in the next spin.
> Quick check for machines sporting no ISA device other than
> isa-serial:
[snip]
> Machines with neither kind of device:
>
> cris-softmmu/qemu-system-cris
> lm32-softmmu/qemu-system-lm32
> microblaze-softmmu/qemu-system-microblaze
> microblazeel-softmmu/qemu-system-microblazeel
> or32-softmmu/qemu-system-or32
> tricore-softmmu/qemu-system-tricore
> xtensa-softmmu/qemu-system-xtensa
> xtensaeb-softmmu/qemu-system-xtensaeb
>
> I figure none of them has a use for isa-serial after PATCH 6. Shouldn't
> we drop CONFIG_SERIAL_ISA for all of them, not just microblaze, xtensa
> and or32?
cris, lm32 and tricore don't have CONFIG_SERIAL at all, so that only
leaves microblaze, xtensa and or32.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-03-31 5:35 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-06 4:18 [Qemu-devel] [PATCH 0/6] Clean up ISA dependencies so we make ISA optional to build David Gibson
2015-03-06 4:18 ` [Qemu-devel] [PATCH 1/6] Split serial-isa into its own config option David Gibson
2015-03-30 7:28 ` Markus Armbruster
2015-03-31 5:36 ` David Gibson [this message]
2015-03-06 4:18 ` [Qemu-devel] [PATCH 2/6] Remove monitor.c dependency on CONFIG_I8259 David Gibson
2015-03-30 7:49 ` Markus Armbruster
2015-03-30 8:37 ` Markus Armbruster
2015-03-31 0:05 ` David Gibson
2015-03-31 9:57 ` Markus Armbruster
2015-04-01 0:40 ` David Gibson
2015-03-30 21:41 ` Andreas Färber
2015-03-31 10:07 ` Peter Maydell
2015-03-06 4:18 ` [Qemu-devel] [PATCH 3/6] pc: Use MachineClass callbacks for "irq" and "pic" hmp commands David Gibson
2015-03-30 21:47 ` Andreas Färber
2015-03-06 4:18 ` [Qemu-devel] [PATCH 4/6] target-ppc: Convert PReP to machine class David Gibson
2015-03-30 21:33 ` Andreas Färber
2015-03-31 5:40 ` David Gibson
2015-03-06 4:18 ` [Qemu-devel] [PATCH 5/6] prep: Use MachineClass callbacks for "irq" and "pic" hmp commands David Gibson
2015-03-30 21:25 ` Andreas Färber
2015-03-06 4:18 ` [Qemu-devel] [PATCH 6/6] Allow ISA bus to be configured out David Gibson
2015-03-06 11:41 ` [Qemu-devel] [PATCH 0/6] Clean up ISA dependencies so we make ISA optional to build Alexander Graf
2015-03-10 14:20 ` Michael S. Tsirkin
2015-03-10 14:56 ` Luiz Capitulino
2015-03-30 2:41 ` David Gibson
2015-03-30 8:48 ` Markus Armbruster
2015-03-30 17:45 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150331053634.GC13452@voom.redhat.com \
--to=david@gibson.dropbear.id.au \
--cc=agraf@suse.de \
--cc=andreas.faerber@web.de \
--cc=armbru@redhat.com \
--cc=blauwirbel@gmail.com \
--cc=lcapitulino@redhat.com \
--cc=michael@walle.cc \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).