From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45544) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ycoq9-000511-4M for qemu-devel@nongnu.org; Tue, 31 Mar 2015 01:35:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ycoq4-0001Cf-Hw for qemu-devel@nongnu.org; Tue, 31 Mar 2015 01:35:52 -0400 Date: Tue, 31 Mar 2015 16:36:34 +1100 From: David Gibson Message-ID: <20150331053634.GC13452@voom.redhat.com> References: <1425615506-1829-1-git-send-email-david@gibson.dropbear.id.au> <1425615506-1829-2-git-send-email-david@gibson.dropbear.id.au> <87y4mfvt94.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="f0KYrhQ4vYSV2aJu" Content-Disposition: inline In-Reply-To: <87y4mfvt94.fsf@blackfin.pond.sub.org> Subject: Re: [Qemu-devel] [PATCH 1/6] Split serial-isa into its own config option List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: agraf@suse.de, mst@redhat.com, qemu-devel@nongnu.org, michael@walle.cc, lcapitulino@redhat.com, blauwirbel@gmail.com, andreas.faerber@web.de, qemu-ppc@nongnu.org --f0KYrhQ4vYSV2aJu Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Mar 30, 2015 at 09:28:39AM +0200, Markus Armbruster wrote: > David Gibson writes: >=20 > > At present, the core device model code for 8250-like serial ports > > (serial.c) and the code for serial ports attached to ISA-style legacy IO > > (serial-isa.c) are both controlled by the CONFIG_ISA variable. > > > > There are lots and lots of embedded platforms that have 8250-like serial > > ports but have never had anything resembling ISA legacy IO. Therefore, > > split serial-isa into its own CONFIG_SERIAL_ISA option so it can be > > disabled for platforms where it's not appropriate. > > > > For now, I enabled CONFIG_SERIAL_ISA in every default-config where > > CONFIG_SERIAL is enabled, excepting microblaze and xtensa, where it's > > pretty clear there isn't legacy IO stuff. >=20 > Related: in PATCH 6, you configure ISA support away for a bunch of > machines. This includes device isabus-bridge. You keep it for machines > sporting PCI. >=20 > > Signed-off-by: David Gibson > > --- > > default-configs/alpha-softmmu.mak | 1 + > > default-configs/arm-softmmu.mak | 1 + > > default-configs/i386-softmmu.mak | 1 + > > default-configs/mips-softmmu.mak | 1 + > > default-configs/mips64-softmmu.mak | 1 + > > default-configs/mips64el-softmmu.mak | 1 + > > default-configs/mipsel-softmmu.mak | 1 + > > default-configs/moxie-softmmu.mak | 1 + > > default-configs/ppc-softmmu.mak | 1 + > > default-configs/ppc64-softmmu.mak | 1 + > > default-configs/ppcemb-softmmu.mak | 1 + > > default-configs/sh4-softmmu.mak | 1 + > > default-configs/sh4eb-softmmu.mak | 1 + > > default-configs/sparc64-softmmu.mak | 1 + > > default-configs/x86_64-softmmu.mak | 1 + > > hw/char/Makefile.objs | 3 ++- > > 16 files changed, 17 insertions(+), 1 deletion(-) >=20 > In addition for not adding CONFIG_SERIAL_ISA to microblaze and xtensa, > you don't seem to add it to or32. If that's correct, please adjust your > commit message. Oops. I think I first wrote this patch on a downstream qemu, and forgot to update the commit message when the or32 case was added when I ported upstream. Will fix in the next spin. > Quick check for machines sporting no ISA device other than > isa-serial: [snip] > Machines with neither kind of device: >=20 > cris-softmmu/qemu-system-cris > lm32-softmmu/qemu-system-lm32 > microblaze-softmmu/qemu-system-microblaze > microblazeel-softmmu/qemu-system-microblazeel > or32-softmmu/qemu-system-or32 > tricore-softmmu/qemu-system-tricore > xtensa-softmmu/qemu-system-xtensa > xtensaeb-softmmu/qemu-system-xtensaeb >=20 > I figure none of them has a use for isa-serial after PATCH 6. Shouldn't > we drop CONFIG_SERIAL_ISA for all of them, not just microblaze, xtensa > and or32? cris, lm32 and tricore don't have CONFIG_SERIAL at all, so that only leaves microblaze, xtensa and or32. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --f0KYrhQ4vYSV2aJu Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJVGjJiAAoJEGw4ysog2bOSl4UQAJDX/FnJzvqWsfMWHttPhPsL gYmEUe2Tlh7pHcbLD+aBJ8Zwl8kM+fXYo+a5Vxa9qGUamEH0Obfj+nzg/CQsvnFP NcMOcZ3M+z3brAdKvv6b93xXleB54DVzp+EJpZPmC5f54tkYQbVY0z0e8PX3JZrK MKApzFMX4Q/MuSbO/bJr03FIfl+tkRWvf6v+hl7RetyZS5EREtzBw5WEfYbRv/Fq kNsfb2PjjDSPsqUaSl7fAfRok7XePupoD56VFbNPUpE9hXmOcfksdXGCSEtR93BS E2TG6TTF+tX0Fa0o8O1SCvwmFWj7uIR5M7MXCQgXN+n1Xe38dffX3EGaaBtPCnPQ uGGSi1l2fG6LdKH8NsHaVTG9gOt+ZKwmZkK+ddVOQ+Ooqom5WPY8n/RZnGqo5UQO qkplcGZjbWiKzdKGrXJ2cO7a6V6GDtuKf2yhfyQCD0fgUHoY+uWZmi0RWpPae7bc 5DrbvIPOrvPTh8Vi56gI+O9DnV0lWeXxZ8agFcs6vCUX2sNQafzHBc5PxU7sfyeT gq1lEdLSLdMOnSeWUsCd7OnjF8MysRK2YRc4Fygv/ogAomMW5JfpcxUDElJ4nhd2 yW9BUmKjdbJk6bih72b1iogfiX7T9GTUYIUFxtdX948lxaPL0XrpKtvX/X3ae5ZE jun/RppTOabPA8HFdEVD =6hfo -----END PGP SIGNATURE----- --f0KYrhQ4vYSV2aJu--