Re: [Qemu-devel] [PATCH 4/6] target-ppc: Convert PReP to machine class

[David Gibson <david@gibson.dropbear.id.au>]

[-- Attachment #1: Type: text/plain, Size: 1358 bytes --]

On Mon, Mar 30, 2015 at 11:33:43PM +0200, Andreas Färber wrote:
> Am 06.03.2015 um 05:18 schrieb David Gibson:
> > The more commonly used ppc machine types: spapr, and newworld Mac have
> > already been converted to the newer MachineClass representation, but some
> > others still use QEMUMachine.
> > 
> > This patch cleans things up slightly, by converting the "prep" machine
> > type to the new style.
> > 
> > Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
> > ---
> >  hw/ppc/prep.c | 30 +++++++++++++++++++++---------
> >  1 file changed, 21 insertions(+), 9 deletions(-)
> > 
> > diff --git a/hw/ppc/prep.c b/hw/ppc/prep.c
> > index 15df7f3..dfc8689 100644
> > --- a/hw/ppc/prep.c
> > +++ b/hw/ppc/prep.c
> > @@ -44,6 +44,8 @@
> >  #include "exec/address-spaces.h"
> >  #include "elf.h"
> >  
> > +#define TYPE_PREP_MACHINE "PReP-machine"
> [snip]
> 
> qemu_register_machine() generated the type name by concatenating
> QEMUMachine::name with "-machine", so this should be "prep-machine".

Ah, I thought the type names were internal only and therefore
changeable.  I've corrected this.

> Otherwise looks great.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]