From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48657) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ycp7W-00044m-Lr for qemu-devel@nongnu.org; Tue, 31 Mar 2015 01:53:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ycp7S-0006D7-JL for qemu-devel@nongnu.org; Tue, 31 Mar 2015 01:53:50 -0400 Date: Tue, 31 Mar 2015 16:40:44 +1100 From: David Gibson Message-ID: <20150331054044.GD13452@voom.redhat.com> References: <1425615506-1829-1-git-send-email-david@gibson.dropbear.id.au> <1425615506-1829-5-git-send-email-david@gibson.dropbear.id.au> <5519C137.3070107@web.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="/3yNEOqWowh/8j+e" Content-Disposition: inline In-Reply-To: <5519C137.3070107@web.de> Subject: Re: [Qemu-devel] [PATCH 4/6] target-ppc: Convert PReP to machine class List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andreas =?iso-8859-1?Q?F=E4rber?= Cc: mst@redhat.com, qemu-devel@nongnu.org, agraf@suse.de, lcapitulino@redhat.com, blauwirbel@gmail.com, michael@walle.cc, qemu-ppc@nongnu.org --/3yNEOqWowh/8j+e Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Mar 30, 2015 at 11:33:43PM +0200, Andreas F=E4rber wrote: > Am 06.03.2015 um 05:18 schrieb David Gibson: > > The more commonly used ppc machine types: spapr, and newworld Mac have > > already been converted to the newer MachineClass representation, but so= me > > others still use QEMUMachine. > >=20 > > This patch cleans things up slightly, by converting the "prep" machine > > type to the new style. > >=20 > > Signed-off-by: David Gibson > > --- > > hw/ppc/prep.c | 30 +++++++++++++++++++++--------- > > 1 file changed, 21 insertions(+), 9 deletions(-) > >=20 > > diff --git a/hw/ppc/prep.c b/hw/ppc/prep.c > > index 15df7f3..dfc8689 100644 > > --- a/hw/ppc/prep.c > > +++ b/hw/ppc/prep.c > > @@ -44,6 +44,8 @@ > > #include "exec/address-spaces.h" > > #include "elf.h" > > =20 > > +#define TYPE_PREP_MACHINE "PReP-machine" > [snip] >=20 > qemu_register_machine() generated the type name by concatenating > QEMUMachine::name with "-machine", so this should be "prep-machine". Ah, I thought the type names were internal only and therefore changeable. I've corrected this. > Otherwise looks great. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --/3yNEOqWowh/8j+e Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJVGjNcAAoJEGw4ysog2bOSYm0P+gOPU/YXS20TvkJj4W7d+Uia KZx0MJtO2+BUZN6VWWc8XFolECPMXoRXLaCxhSF8e71zUyNQDpjZru7LWtRJP/wO fh8mBBYXJqoWX2vlvOmuzvsgMimz1m6bn2MLocSeCQ/JoZ3qySgaZpBxqahbaUra ezuSyjfWQCD0hyiRSWZz2S1AFtR1JH2kPt+apBK7WnD8+hT4u18m0NHW/1tBczDR HTuoaE0QojvUbr8I6WylRKWq2KX6TSfDotNXYpCkRON2MYi4qLkAMFItalaNVItd E6c0fC+0vGFP+zly8DccC7q/hmkzNWEA1R0neAfaAHtZgkvK2ppDL9wTwAyy34NM gfQ+xK7Ij9p8OeGpx4yZ56wOdPe8XY0ERqmpZag0Ym0FhMwunXaPfGcxrlOXxXrw CiQhzeYOMKnJ8AsovF4CzW90Rgtt3oAcU8K4GvzHH7LVeY8Pg1Zd2PtjNP8VRN8O OQjVyxu/hV9XP9DLv7/VgXXwxzKwhlNgJ792n1aH73sbmyT6NHUEs/kNGYc0jABX WVtUOvlWRCD+o89BSdYsH8vzp+optUPX7NE69IbHLu9BF9AUpQIn7Uig96I4zMpe O76yZIlgX/QKJ44Cj0Gary3fURWBRK+ki48DVoOf08uwFHFPcKK9v0Q0HrlmFML/ Vg72bwb0bRTZAHyrpIXt =g7Vl -----END PGP SIGNATURE----- --/3yNEOqWowh/8j+e--