From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36156) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YcuEQ-0002Lp-1I for qemu-devel@nongnu.org; Tue, 31 Mar 2015 07:21:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YcuEJ-00022z-VY for qemu-devel@nongnu.org; Tue, 31 Mar 2015 07:21:17 -0400 Received: from e06smtp14.uk.ibm.com ([195.75.94.110]:44881) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YcuEJ-00022W-Nk for qemu-devel@nongnu.org; Tue, 31 Mar 2015 07:21:11 -0400 Received: from /spool/local by e06smtp14.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 31 Mar 2015 12:21:10 +0100 Received: from b06cxnps4075.portsmouth.uk.ibm.com (d06relay12.portsmouth.uk.ibm.com [9.149.109.197]) by d06dlp03.portsmouth.uk.ibm.com (Postfix) with ESMTP id 44FA41B0805F for ; Tue, 31 Mar 2015 12:21:36 +0100 (BST) Received: from d06av05.portsmouth.uk.ibm.com (d06av05.portsmouth.uk.ibm.com [9.149.37.229]) by b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t2VBL73x3473842 for ; Tue, 31 Mar 2015 11:21:07 GMT Received: from d06av05.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av05.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t2VBL7rZ028319 for ; Tue, 31 Mar 2015 05:21:07 -0600 Date: Tue, 31 Mar 2015 13:21:05 +0200 From: Michael Mueller Message-ID: <20150331132105.68936bee@bee> In-Reply-To: <20150330201721.GF7031@thinpad.lan.raisama.net> References: <1427725708-52100-1-git-send-email-mimu@linux.vnet.ibm.com> <1427725708-52100-12-git-send-email-mimu@linux.vnet.ibm.com> <20150330201721.GF7031@thinpad.lan.raisama.net> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v4 11/15] target-s390x: New QMP command query-cpu-model List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: linux-s390@vger.kernel.org, Cornelia Huck , kvm@vger.kernel.org, Gleb Natapov , qemu-devel@nongnu.org, linux-kernel@vger.kernel.org, Christian Borntraeger , Alexander Graf , "Jason J. Herne" , Daniel Hansel , Paolo Bonzini , Andreas Faerber , Richard Henderson On Mon, 30 Mar 2015 17:17:21 -0300 Eduardo Habkost wrote: > On Mon, Mar 30, 2015 at 04:28:24PM +0200, Michael Mueller wrote: > > This patch implements a new QMP request named 'query-cpu-model'. > > It returns the cpu model of cpu 0 and its backing accelerator. > > > > request: > > {"execute" : "query-cpu-model" } > > > > answer: > > {"return" : {"name": "2827-ga2", "accel": "kvm" }} > > If you are returning information about an existing CPU, why not just > extend the output of "query-cpus"? > > (Existing qmp_query_cpus() calls cpu_synchronize_state(), which may be > undesired. But in this case we could add an optional parameter to > disable the return of data that requires stopping the VCPU). Will the cpu_cpu_syncronize_state() really hurt in real life? query-cpus will be called only once a while... I will prepare the extension of query-cpus as an option but initially without the optional parameter. > > > > > Alias names are resolved to their respective machine type and GA names > > already during cpu instantiation. Thus, also a cpu model like 'host' > > which is implemented as alias will return its normalized cpu model name. > > > > Furthermore the patch implements the following function: > > > > - s390_cpu_models_used(), returns true if S390 cpu models are in use > > > > Signed-off-by: Michael Mueller > [...] > Thanks, Michael