From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38278)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1Ycy1N-0007W9-Q0
	for qemu-devel@nongnu.org; Tue, 31 Mar 2015 11:24:09 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1Ycy1K-0005fH-K1
	for qemu-devel@nongnu.org; Tue, 31 Mar 2015 11:24:05 -0400
Received: from mx1.redhat.com ([209.132.183.28]:47054)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1Ycy1K-0005fA-FN
	for qemu-devel@nongnu.org; Tue, 31 Mar 2015 11:24:02 -0400
Date: Tue, 31 Mar 2015 17:23:59 +0200
From: Kevin Wolf <kwolf@redhat.com>
Message-ID: <20150331152359.GC4748@noname.redhat.com>
References: <1427227433-5030-1-git-send-email-eblake@redhat.com>
	<1427227433-5030-18-git-send-email-eblake@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1427227433-5030-18-git-send-email-eblake@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v5 17/28] qapi: Allow true,
	false and null in schema json
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>
Cc: armbru@redhat.com, famz@redhat.com, qemu-devel@nongnu.org, wenchaoqemu@gmail.com, lcapitulino@redhat.com

Am 24.03.2015 um 21:03 hat Eric Blake geschrieben:
> From: Fam Zheng <famz@redhat.com>
> 
> In the near term, we will use it for a sensible-looking
> 'gen':false inside command declarations, instead of the
> current ugly 'gen':'no'.
> 
> In the long term, it will allow conversion from shorthand
> with defaults mentioned only in side-band documentation:
>  'data':{'*flag':'bool', '*string':'str'}
> into an explicit default value documentation, as in:
>  'data':{'flag':{'type':'bool', 'optional':true, 'default':true},
>          'string':{'type':'str', 'optional':true, 'default':null}}

FWIW, I don't think that's a very friendly syntax for humans, it's a bit
verbose. But that's no reason not to allow true/false/null, of course.

> We still don't parse integer values (also necessary before
> we can allow explicit defaults), but that can come in a later
> series.
> 
> Update the testsuite to match an improved error message.
> 
> Signed-off-by: Fam Zheng <famz@redhat.com>
> Signed-off-by: Eric Blake <eblake@redhat.com>

Kevin