From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54255) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yd7oZ-00064Z-L8 for qemu-devel@nongnu.org; Tue, 31 Mar 2015 21:51:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yd7oY-0001LB-FT for qemu-devel@nongnu.org; Tue, 31 Mar 2015 21:51:31 -0400 Date: Wed, 1 Apr 2015 11:40:13 +1100 From: David Gibson Message-ID: <20150401004013.GA23677@voom.redhat.com> References: <1425615506-1829-1-git-send-email-david@gibson.dropbear.id.au> <1425615506-1829-3-git-send-email-david@gibson.dropbear.id.au> <87mw2vvsao.fsf@blackfin.pond.sub.org> <87384mvq1y.fsf@blackfin.pond.sub.org> <20150331000524.GN9908@voom.fritz.box> <87k2xxa3qv.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="huq684BweRXVnRxX" Content-Disposition: inline In-Reply-To: <87k2xxa3qv.fsf@blackfin.pond.sub.org> Subject: Re: [Qemu-devel] [PATCH 2/6] Remove monitor.c dependency on CONFIG_I8259 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: agraf@suse.de, mst@redhat.com, qemu-devel@nongnu.org, lcapitulino@redhat.com, blauwirbel@gmail.com, michael@walle.cc, qemu-ppc@nongnu.org, andreas.faerber@web.de --huq684BweRXVnRxX Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Mar 31, 2015 at 11:57:28AM +0200, Markus Armbruster wrote: > David Gibson writes: >=20 > > On Mon, Mar 30, 2015 at 10:37:45AM +0200, Markus Armbruster wrote: > [...] > >> This adds "info irq" and "info pic" to the targets that didn't have th= em > >> before, implemented by i8259.c's hmp_info_pic() and hmp_info_irq(). > >> They do nothing unless the machine has an "isa-i8259" device. > >>=20 > >> Cases: > >>=20 > >> 1. If the machine has one, and it's the only interrupt controller, the > >> commands work as advertized. > >>=20 > >> 2. If the machine doesn't have one, the commands are empty promises. > >>=20 > >> 3. If the machine has one, but it's not the only interrupt controller, > >> the commands confidently claim the i8259 is all there is. > >> Misinformation. > >>=20 > >> Cases 2 and 3 are common, case 1 is rare. > >>=20 > >> We can: > >>=20 > >> A. Fix the commands to cover all interrupt controllers. > >>=20 > >> B. Fix them to warn the user about missing interrupt controllers. > >>=20 > >> We can approximate this by warning always, because it's almost never > >> the only interrupt controller anyway :) > >>=20 > >> C. Rip 'em both out and be done with it. > >>=20 > >> D. Do nothing. > >>=20 > >> E. Provide them as is on all targets. > >>=20 > >> Spread the badness fairly. > >>=20 > >> I vote for C or B. A seems not worthwhile. > > > > I'd love to do C, if we can get confirmation that no-one's really > > using the existing HMP commands. That would make a bunch of things > > simpler. >=20 > I gave it a shot, let's see how people react. Heh, you beat me to it. Thanks for the detailed analysis. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --huq684BweRXVnRxX Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJVGz5tAAoJEGw4ysog2bOSjDYP/ii58/a6XO/m6q6BH5Uzaord H/nNtn+TnxpxZhOjotpH1Uj9cFbnpoliNfbDyXipfQ2pB67QPdW727bJ8EXXE9k9 S+tWV5/4/HNXzS7NyGmva4CzJr7QzJPJC76Lwk4qBNtsBzHTy0DZGxJfJAU1/O1t DZSuhbSYAggaIXwR4zx9AlOEoqtIr5cdKDfviNlzBYistJRQblPM1RtExoIEeyIK ycoV7KZLK9l+e/hZj+Jg2TiwXBRG99eUpSUJbERMNlPjobmSPfBPgCT0q8L4jcLx PLQQe3DwDciNOEmOokBCI3pdjeuelSsxNM13CpGK/iSPNcFcdcdQ5rZu5rZGq902 L6jd+4vSLJS+22JnbCjxPDYxzBVN+o7PyqD6hiK5MwBrCQV6Vm23lHPfmMOpXDIR huxMHhHxq/kTfSiEls/Gb6H0tG7mi22pcgdUEVpXD8SIrPjsfTBdj8X8lhCKatJx HEzDkMTzz7HfZRWWg2BnWAA3CHIzN/dy9Mgy1vObuKlxbEhTwnwqRNT+ZqP9ZKBq 7mBZJ007LecKq5+I5XZ/7SoB0q8j7Xigtj1IR0RLkKuAzqYiHqDGa0q3l9ZWxtlP e6ELlb8ga269kX/Ip9YBAvKIQKQYUw3KHobbntDZcvBWeQUFSyhDyIyAiluc/blM ocCsSgTK84td+YIxIS8h =n1vj -----END PGP SIGNATURE----- --huq684BweRXVnRxX--