From: Alberto Garcia <berto@igalia.com>
To: Fam Zheng <famz@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 6/7] throttle: add the name of the ThrottleGroup to BlockDeviceInfo
Date: Wed, 1 Apr 2015 12:06:08 +0200 [thread overview]
Message-ID: <20150401100608.GA13383@igalia.com> (raw)
In-Reply-To: <20150401095940.GB2777@fam-t430.nay.redhat.com>
On Wed, Apr 01, 2015 at 05:59:40PM +0800, Fam Zheng wrote:
> > info->has_iops_size = cfg.op_size;
> > info->iops_size = cfg.op_size;
> > +
> > + info->has_group = true;
> > + info->group = g_strdup(throttle_group_get_name(bs));
>
> True even if it's unset?
Note that that's inside an "if (bs->io_limits_enabled)" block.
io_limits_enabled is set immediately after adding a BDS to a
throttling group, and that requires a name.
> > +# @group: #optional throttle group name (Since 2.3)
>
> Will probably be 2.4.
Right.
Berto
next prev parent reply other threads:[~2015-04-01 10:06 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-30 16:19 [Qemu-devel] [PATCH v6 0/7] Block Throttle Group Support Alberto Garcia
2015-03-30 16:19 ` [Qemu-devel] [PATCH 1/7] throttle: Extract timers from ThrottleState into a separate structure Alberto Garcia
2015-03-30 16:19 ` [Qemu-devel] [PATCH 2/7] throttle: Add throttle group infrastructure Alberto Garcia
2015-04-09 12:28 ` Stefan Hajnoczi
2015-03-30 16:19 ` [Qemu-devel] [PATCH 3/7] throttle: Add throttle group infrastructure tests Alberto Garcia
2015-04-01 10:00 ` Fam Zheng
2015-04-09 12:30 ` Stefan Hajnoczi
2015-03-30 16:19 ` [Qemu-devel] [PATCH 4/7] throttle: Add throttle group support Alberto Garcia
2015-04-01 14:44 ` Fam Zheng
2015-04-01 15:18 ` Alberto Garcia
2015-04-02 3:26 ` Fam Zheng
2015-04-02 7:36 ` Alberto Garcia
2015-04-09 14:22 ` Stefan Hajnoczi
2015-04-10 7:58 ` Alberto Garcia
2015-04-10 9:52 ` Stefan Hajnoczi
2015-04-10 9:55 ` Alberto Garcia
2015-03-30 16:19 ` [Qemu-devel] [PATCH 5/7] throttle: acquire the ThrottleGroup lock in bdrv_swap() Alberto Garcia
2015-03-30 16:19 ` [Qemu-devel] [PATCH 6/7] throttle: add the name of the ThrottleGroup to BlockDeviceInfo Alberto Garcia
2015-04-01 9:59 ` Fam Zheng
2015-04-01 10:06 ` Alberto Garcia [this message]
2015-04-01 14:05 ` Fam Zheng
2015-03-30 16:19 ` [Qemu-devel] [PATCH 7/7] throttle: Update throttle infrastructure copyright Alberto Garcia
-- strict thread matches above, loose matches on Subject: below --
2015-03-30 14:16 [Qemu-devel] [PATCH v5 0/7] Block Throttle Group Support Alberto Garcia
2015-03-30 14:16 ` [Qemu-devel] [PATCH 6/7] throttle: add the name of the ThrottleGroup to BlockDeviceInfo Alberto Garcia
2015-03-26 17:24 [Qemu-devel] [PATCH v4 0/7] Block Throttle Group Support Alberto Garcia
2015-03-26 17:25 ` [Qemu-devel] [PATCH 6/7] throttle: add the name of the ThrottleGroup to BlockDeviceInfo Alberto Garcia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150401100608.GA13383@igalia.com \
--to=berto@igalia.com \
--cc=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).