Re: [Qemu-devel] [PATCH 4/7] throttle: Add throttle group support

[Alberto Garcia <berto@igalia.com>]

On Thu, Apr 02, 2015 at 11:26:30AM +0800, Fam Zheng wrote:

> > > Thinking about this, I'd slightly prefer a canonical throttle
> > > group definition rather than patching the existing parameters:
> > > 
> > > -object throttle-group,id=tg0,bps=100,iops=200,iops-max=1000 \
> > > -drive file=foo,id=foo,throttle-group=tg0 \
> > > -drive file=bar,id=bar,throttle-group=tg0 \
> > > 
> > > and error out if "bps=" etc are specified together with
> > > "throttle-group=" in -drive.
> > > 
> > > And in QMP, add block_set_io_throttle_group which works together
> > > with object-add.
>
> > My first impression is that the idea is feasible, but I'm unsure
> > at the moment of its complexity or possible side effects.
>
> I think it is a cleaner model and easier to understand. What
> complexity are you referring to?

The changes on the code. At first sight it seems that it should not
be too difficult to convert the current implementation (and API) into
the one you are proposing, but I'll wait for a few days to hear other
opinions before attempting to rewrite it :)

Berto